[MDEP-858] Complete Maven Artifact Transfer removal after #1677 - #1680
Open
wilx wants to merge 5 commits into
Open
[MDEP-858] Complete Maven Artifact Transfer removal after #1677#1680wilx wants to merge 5 commits into
wilx wants to merge 5 commits into
Conversation
wilx
marked this pull request as ready for review
August 9, 2026 22:43
wilx
force-pushed
the
issue-1355-on-pr-1677
branch
from
August 10, 2026 06:50
28d423a to
7aa3484
Compare
8 tasks
Contributor
Author
|
@slachiewicz Rebased. |
Member
|
Great, it now looks cleaner. Unfortunetly I've found #1682 that we must somehow address after mergint your's PR |
… Resolver Replace Maven Artifact Transfer installation used by dependency:copy-dependencies in the repository-layout path while preserving Maven local-repository metadata, copied POMs, and snapshot behavior. Fixes apache#1355.
Replace the Maven Artifact Transfer resolvers while preserving dependency filtering, fallback resolution, and aggregated failure reporting. Re-resolve each artifact once because Resolver descriptor resolution also restores its POM. Fixes apache#1355.
Drop the unused DependableCoordinate interface from ArtifactItem and remove the now-unused Maven Artifact Transfer dependency. Keep the artifact configuration getters unchanged. Fixes apache#1355.
Keep dependency:get compatible with its historical behavior by applying the always-update policy to user-supplied repositories. Leave the existing session-controlled policy available to other ResolverUtil callers. Fixes apache#1355.
Use separately configured packaging and classifier values when the artifact string omits those segments. Keep packaging and classifier values from explicit artifact coordinates at higher precedence. Fixes apache#1355.
wilx
force-pushed
the
issue-1355-on-pr-1677
branch
from
August 11, 2026 06:17
7aa3484 to
a79a2ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR is stacked on top of #1677 and is the stacked alternative to #1668. Until #1677 is merged, GitHub's diff also includes its two commits. After #1677 is merged, this PR should contain only the five follow-up commits described below. If this stacked approach is preferred, #1668 can be closed.
Summary
Complete the Maven Artifact Transfer removal after #1677:
dependency:copy-dependenciesto Maven Resolver while preserving local-repository metadata, copied POMs, snapshot base versions, and repository content type;dependency:purge-local-repositoryresolution while preserving filtering, fallback resolution, classifiers, and aggregated failure reporting;maven-artifact-transferdependency andDependableCoordinateimplementation;dependency:get's historical unconditional refresh policy for explicitly supplied repositories while leaving otherResolverUtilcallers session-controlled;The repository parsing, strict artifact-coordinate validation, and
dependency:getResolver migration come from #1677.Fixes #1355
Verification
nice mvn clean verify— 434 tests, 0 failures/errors, 1 skipped; dependency analysis cleannice mvn clean -Prun-its verify— 99 Invoker projects passed, 0 failed/errors/skippedTestGetMojo,ResolverUtilTest, andTestCopyDependenciesMojo2clean run — 43 tests, 0 failures/errors/skipsget-*Invoker run — 4 passed, 0 failed/errors/skippedspotless:checkpassed on every follow-up commit revision;git diff --checkpassed on the final headFollowing this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.