feat(runtime-host): accept WebRTC direct upgrades - #4404
Merged
M4n5ter merged 3 commits intoSep 1, 2026
Merged
Conversation
M4n5ter
force-pushed
the
feat/runtime-host-webrtc-direct-upgrade
branch
from
August 31, 2026 22:46
4f33795 to
e1f2022
Compare
M4n5ter
marked this pull request as ready for review
September 1, 2026 00:00
jackwener
approved these changes
Sep 1, 2026
jackwener
left a comment
Member
There was a problem hiding this comment.
Approved at exact head e1f2022932cdd9d18698d26d9acdd4be1efa13a3 at the explicit direction of M4n5ter. No technical review was performed as part of this action; M4n5ter requested the approval and accepts responsibility for subsequent handling.
Review notice: This approval was submitted by an automated review agent operated by WAWQAQ and is published at the direction of M4n5ter, who requested this action and is the human accountable for it.
abhinav-phi
pushed a commit
to abhinav-phi/maka
that referenced
this pull request
Sep 1, 2026
* feat(runtime-host): accept WebRTC direct upgrades * fix(runtime-host): bound WebRTC substream resources * fix(native): close discarded WebRTC transports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English
Outcome
Add an experimental private-to-private WebRTC direct upgrade inside the existing Rust libp2p peer endpoint. Signaling runs over the already Noise-authenticated Circuit Relay v2 connection, and the resulting connection enters the same Swarm, PeerId, muxing, and Runtime Host application protocol.
Architecture boundary
/webrtc-signaling/0.0.1; no Maka signaling service or private wire protocol.The temporary dependency is pinned to immutable
webrtcrevisione132552fc67b84c30e63c5ce916a9a63e2484b6f, which contains the DataChannel readiness fixes documented in #4382. It never tracks a floating branch.This is stack 2/4 for #4382.
Verification
cargo fmt --check, clippy with warnings denied, and native tests.cargo deny --locked --exclude-dev check licenses.中文
结果
在现有 Rust libp2p peer endpoint 内加入实验性的 private-to-private WebRTC 直连升级。Signaling 复用已经通过 Noise 认证的 Circuit Relay v2 connection;建立后的 connection 进入同一个 Swarm、PeerId、mux 与 Runtime Host 应用协议。
架构边界
/webrtc-signaling/0.0.1,不增加 Maka signaling service 或私有 wire。临时依赖精确固定到
webrtcrevisione132552fc67b84c30e63c5ce916a9a63e2484b6f;它包含 #4382 记录的 DataChannel readiness 修复,且不会跟随浮动分支。这是 #4382 的第 2/4 层。
验证
cargo fmt --check、clippy 零警告与 native tests。cargo deny --locked --exclude-dev check licenses。AI use
Tool(s) and scope: OpenAI Codex implemented, qualified, and documented the native WebRTC transport under human direction. The human contributor owns review and merge decisions.
Checklist