chore(deps): bump @astryxdesign/core from 0.5.0 to 0.5.2 - #4372
Conversation
hqhq1025
left a comment
There was a problem hiding this comment.
Reviewed exact head df66e732ff18345b2c94161a35dcbec570de6361: 2 P1 findings; not ready to merge.
The reported main-branch compile failure does not reproduce with the repository's standard clean install: npm ci && npm run build passes on current main 89d4b0e, because the checked-in @astryxdesign/core@0.5.0 patch still restores both removed APIs. The PR build and typecheck pass, but the full UI suite fails 5 of 276 tests after moving math preprocessing ahead of Astryx's streaming cursor. Removing the patched auto-scroll switch also restores a second scroll writer on host-owned transcript surfaces.
Hosted checks were still queued at publication. I could not run the Electron scroll integration in this Linux session because no display server is available.
Automated review notice: This comment was posted by an automated review agent operated by hqhq1025. It is not an independent human review and does not replace one.
Astro-Han
left a comment
There was a problem hiding this comment.
LGTM. Astryx is moving fast so we need to bump it regularly.
@astryxdesign/core@0.5.0 removed two props that @maka/ui relied on: 1. ChatLayout: `autoScroll` prop removed (auto-scroll now managed internally via useChatStreamScroll hook). 2. Markdown: `transformSource` prop removed (no longer accepts source text transformation). Apply math source transformation before passing text as children instead of using the removed prop, and remove the autoScroll prop from ChatLayout usage.
Generated-by: OpenAI Codex
6ca5c5d to
46d519b
Compare
Summary
Upgrade the synchronized Astryx packages from
0.5.0to0.5.2and rebuild Maka's single compatibility patch for the published package.The patch preserves the contracts Maka actually relies on:
ChatLayout.autoScroll, soscrollOwner="host"leavesTranscriptScrollAuthorityas the sole scrollTop writer.Markdown.transformSourceandsettledText, so math display transformation runs after Astryx's raw streaming cursor and settled-prefix identity remains intact.This intentionally keeps both Maka call sites; removing them compiles against the unpatched declarations but regresses streamed math and host-owned scrolling.
Fixes #4371
Verification
@astryxdesign/core@0.5.2and@astryxdesign/theme-neutral@0.5.2are pinned in manifests and lockfile.patches/@astryxdesign+core+0.5.2.patchapplies cleanly to a pristine0.5.2package (git apply --check).git diff --checkpasses.AI use
Tool(s) and scope: opencode — diagnosed the package compatibility boundary and helped rebuild the versioned patch.
Checklist
0.5.2patchDoes this PR entail a change in behavior?