Skip to content

chore(deps): bump @astryxdesign/core from 0.5.0 to 0.5.2 - #4372

Merged
me2seeks merged 10 commits into
apache:mainfrom
me2seeks:fix/ui-build-astryx-0.5.0
Sep 1, 2026
Merged

chore(deps): bump @astryxdesign/core from 0.5.0 to 0.5.2#4372
me2seeks merged 10 commits into
apache:mainfrom
me2seeks:fix/ui-build-astryx-0.5.0

Conversation

@me2seeks

@me2seeks me2seeks commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Upgrade the synchronized Astryx packages from 0.5.0 to 0.5.2 and rebuild Maka's single compatibility patch for the published package.

The patch preserves the contracts Maka actually relies on:

  • ChatLayout.autoScroll, so scrollOwner="host" leaves TranscriptScrollAuthority as the sole scrollTop writer.
  • Markdown.transformSource and settledText, so math display transformation runs after Astryx's raw streaming cursor and settled-prefix identity remains intact.

This intentionally keeps both Maka call sites; removing them compiles against the unpatched declarations but regresses streamed math and host-owned scrolling.

Fixes #4371

Verification

  • @astryxdesign/core@0.5.2 and @astryxdesign/theme-neutral@0.5.2 are pinned in manifests and lockfile.
  • The rebuilt patches/@astryxdesign+core+0.5.2.patch applies cleanly to a pristine 0.5.2 package (git apply --check).
  • git diff --check passes.
  • Full clean-install CI remains the final verification of patch-package application and the complete test suite.

AI use

  • Generative tooling made a substantive contribution

Tool(s) and scope: opencode — diagnosed the package compatibility boundary and helped rebuild the versioned patch.

Checklist

  • Tests cover the affected streaming and scroll contracts in the repository
  • Clean-install CI and all affected suites pass on the pushed 0.5.2 patch

Does this PR entail a change in behavior?

  • Yes — it preserves existing Maka scroll ownership and streaming Markdown behavior while changing the dependency/patch baseline.
  • No

@me2seeks
me2seeks requested a review from Astro-Han August 31, 2026 14:54

@hqhq1025 hqhq1025 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head df66e732ff18345b2c94161a35dcbec570de6361: 2 P1 findings; not ready to merge.

The reported main-branch compile failure does not reproduce with the repository's standard clean install: npm ci && npm run build passes on current main 89d4b0e, because the checked-in @astryxdesign/core@0.5.0 patch still restores both removed APIs. The PR build and typecheck pass, but the full UI suite fails 5 of 276 tests after moving math preprocessing ahead of Astryx's streaming cursor. Removing the patched auto-scroll switch also restores a second scroll writer on host-owned transcript surfaces.

Hosted checks were still queued at publication. I could not run the Electron scroll integration in this Linux session because no display server is available.

Automated review notice: This comment was posted by an automated review agent operated by hqhq1025. It is not an independent human review and does not replace one.

Comment thread packages/ui/src/markdown-body.tsx Outdated
Comment thread packages/ui/src/chat-surface-layout.tsx
@github-actions github-actions Bot added the effort/S Under 100 readable lines label Aug 31, 2026
@me2seeks me2seeks changed the title fix(ui): adapt to @astryxdesign/core@0.5.0 breaking changes fix(build): restore Maka compatibility with @astryxdesign/core@0.5.2 Aug 31, 2026
@me2seeks me2seeks changed the title fix(build): restore Maka compatibility with @astryxdesign/core@0.5.2 chore(deps): bump @astryxdesign/core from 0.5.0 to 0.5.2 Sep 1, 2026

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Astryx is moving fast so we need to bump it regularly.

@github-actions github-actions Bot added effort/L Under 1000 readable lines and removed effort/S Under 100 readable lines labels Sep 1, 2026
@astryxdesign/core@0.5.0 removed two props that @maka/ui relied on:

1. ChatLayout: `autoScroll` prop removed (auto-scroll now managed
   internally via useChatStreamScroll hook).
2. Markdown: `transformSource` prop removed (no longer accepts source
   text transformation).

Apply math source transformation before passing text as children
instead of using the removed prop, and remove the autoScroll prop
from ChatLayout usage.
@me2seeks
me2seeks force-pushed the fix/ui-build-astryx-0.5.0 branch from 6ca5c5d to 46d519b Compare September 1, 2026 06:26
@me2seeks
me2seeks merged commit c03dfce into apache:main Sep 1, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/L Under 1000 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(deps): bump @astryxdesign/core to 0.5.2 with compatibility patch

3 participants