Skip to content

feat(cli): expose ACP session configuration - #4051

Open
Sun-GLiang wants to merge 7 commits into
apache:mainfrom
Sun-GLiang:feat/acp-session-configuration
Open

feat(cli): expose ACP session configuration#4051
Sun-GLiang wants to merge 7 commits into
apache:mainfrom
Sun-GLiang:feat/acp-session-configuration

Conversation

@Sun-GLiang

@Sun-GLiang Sun-GLiang commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Return exactly four ordered ACP select configOptions from the Runtime Host's committed Session projection for every successful session/new: permission mode, thinking level, collaboration mode, and orchestration mode.
  • Track Session ownership per ACP connection without opening Runtime Host subscriptions; session/list never grants ownership.
  • Implement ACP v1 session/set_config_option through the official SDK route, validating ownership, id, type, and value before Host I/O.
  • Apply each live change as a one-field SessionConfigurationPatch CAS update, preserving model selection and unrelated fields, with at most three attempts on revision conflicts.
  • Keep session/set_mode unsupported and unadvertised.

Refs #3132
Depends on #3744 (merged)

Review dependency

Verification

  • npm run build
  • Focused ACP suites — 51 passed, 0 failed.
  • TMPDIR=/private/tmp npm --workspace maka-agent run test:dist — 765 tests: 762 passed, 3 skipped, 0 failed.
  • npm run typecheck
  • npm run lint
  • npm run format:check
  • npm run check:asf-headers
  • git diff upstream/main --check
  • Independent final review found no Critical, Important, or Minor findings.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Codex assisted with design, implementation, tests, verification, checklist alignment, and review. Every PR3 commit includes a Generated-by: Codex trailer.

Checklist

  • Tests cover the change and fail without it
  • Build, lint, format, typecheck, ASF headers, and affected/full CLI suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@Sun-GLiang
Sun-GLiang force-pushed the feat/acp-session-configuration branch from 0bca0ed to dda8f4b Compare September 2, 2026 10:42
@Sun-GLiang
Sun-GLiang marked this pull request as ready for review September 2, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/XL Over 1000 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant