feat(cli): expose ACP session configuration - #4051
Open
Sun-GLiang wants to merge 7 commits into
Open
Conversation
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Sun-GLiang
force-pushed
the
feat/acp-session-configuration
branch
from
September 2, 2026 10:42
0bca0ed to
dda8f4b
Compare
Sun-GLiang
marked this pull request as ready for review
September 2, 2026 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configOptionsfrom the Runtime Host's committed Session projection for every successfulsession/new: permission mode, thinking level, collaboration mode, and orchestration mode.session/listnever grants ownership.session/set_config_optionthrough the official SDK route, validating ownership, id, type, and value before Host I/O.SessionConfigurationPatchCAS update, preserving model selection and unrelated fields, with at most three attempts on revision conflicts.session/set_modeunsupported and unadvertised.Refs #3132
Depends on #3744 (merged)
Review dependency
mainat1581dc1c4after feat(cli): add ACP session creation and listing #3744 merged, so this PR contains only the PR3 delta.Verification
npm run buildTMPDIR=/private/tmp npm --workspace maka-agent run test:dist— 765 tests: 762 passed, 3 skipped, 0 failed.npm run typechecknpm run lintnpm run format:checknpm run check:asf-headersgit diff upstream/main --checkAI use
Select exactly one:
Tool(s) and scope: Codex assisted with design, implementation, tests, verification, checklist alignment, and review. Every PR3 commit includes a
Generated-by: Codextrailer.Checklist
Does this PR entail a change in behavior?