Repository navigation
Conversation
|
Hello @akirn, |
dnskr
approved these changes
Oct 25, 2026
dnskr
pushed a commit
that referenced
this pull request
Oct 25, 2026
…tefulSet annotations
### Why are the changes needed?
The chart only exposes a pod-level `securityContext`. Fields such as `allowPrivilegeEscalation`, `readOnlyRootFilesystem` and `capabilities` exist only on the container `securityContext`, so clusters whose admission policies require them (for example Pod Security Standards "restricted", or Kyverno/Gatekeeper equivalents) can't run the chart without patching the template. This adds a `containerSecurityContext` value applied to the `kyuubi-server` container, as the Apache Polaris and Dagster charts already offer.
It also adds an `annotations` value for the StatefulSet's own metadata. `podAnnotations` only reaches the pod template, but some controllers read the workload's annotations. For example, Stakater Reloader' `secret.reloader.stakater.com/reload` must be on the StatefulSet to roll the pods when a TLS keystore Secret is renewed, since the Kyuubi server reads its keystore only at startup.
Both values default to `{}`, so the rendered output is unchanged for existing users.
### How was this patch tested?
The chart has no unit tests, so this was checked by rendering:
1. `helm lint charts/kyuubi` passes.
2. With default values, `helm template t charts/kyuubi` is byte-identical to master.
3. With both values set:
```
helm template t charts/kyuubi -s templates/kyuubi-statefulset.yaml --set-json 'annotations={"secret.reloader.stakater.com/reload":"kyuubi-tls"}' --set-json
'containerSecurityContext={"allowPrivilegeEscalation":false,"readOnlyRootFilesystem":true,"runAsNonRoot":true,"capabilities":{"drop":["ALL"]}}'
the annotation renders under the StatefulSet's `metadata.annotations` and the security context under the `kyuubi-server` container. The output passes `kubectl apply --dry-run=client`.
```
### Was this patch assisted by generative AI tooling?
No. The patch wasn't assisted. The description was.
cc pan3793 dnskr
Closes #7790 from akirn/helm-container-security-context-and-statefulset-annotations.
Closes #7790
2477b1a [andreas.kirn] [K8S][HELM] Support container security context and StatefulSet annotations
Authored-by: Andreas Kirn <andreas.kirn@servicenow.com>
Signed-off-by: Denis Krivenko <dnskrv88@gmail.com>
(cherry picked from commit 07a5a96)
Signed-off-by: Denis Krivenko <dnskrv88@gmail.com>
Contributor
|
Hi @akirn, thank you for taking the time to improve Kyuubi with this valuable addition to the Helm chart! Merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The chart only exposes a pod-level
securityContext. Fields such asallowPrivilegeEscalation,readOnlyRootFilesystemandcapabilitiesexist only on the containersecurityContext, so clusters whose admission policies require them (for example Pod Security Standards "restricted", or Kyverno/Gatekeeper equivalents) can't run the chart without patching the template. This adds acontainerSecurityContextvalue applied to thekyuubi-servercontainer, as the Apache Polaris and Dagster charts already offer.It also adds an
annotationsvalue for the StatefulSet's own metadata.podAnnotationsonly reaches the pod template, but some controllers read the workload's annotations. For example, Stakater Reloader'secret.reloader.stakater.com/reloadmust be on the StatefulSet to roll the pods when a TLS keystore Secret is renewed, since the Kyuubi server reads its keystore only at startup.Both values default to
{}, so the rendered output is unchanged for existing users.How was this patch tested?
The chart has no unit tests, so this was checked by rendering:
helm lint charts/kyuubipasses.helm template t charts/kyuubiis byte-identical to master.Was this patch assisted by generative AI tooling?
No. The patch wasn't assisted. The description was.
cc @pan3793 @dnskr