ci: isolate kvrocks2redis coverage data#3511
Closed
jihuayu wants to merge 1 commit into
Closed
Conversation
Member
Author
|
The reason for this PR is that I noticed the coverage report in #3502 looked strange. The coverage for |
PragmaTwice
requested changes
Jun 3, 2026
Member
There was a problem hiding this comment.
This is not acceptable to me that the CI time increases by about 35min (1h 24m 59s in total).
See https://github.com/apache/kvrocks/actions/runs/26887545442/job/79334883335?pr=3511.
Member
Author
|
Ummm, I overlooked that. This is indeed unacceptable. I decided to parallelize the build steps for kvrocks2redis and Kvrocks. Do you have a better approach? |
Member
|
You can just disable the kvrocks2redis test in such matrix config.. Please do not increase CI time. It's already too slow.. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The previous
go testcode coverage data could be overwritten by the coverage data fromkvrocks2redis, which caused the overall coverage metric to be lower than expected.This fixes the SonarCloud coverage job so the kvrocks2redis test no longer corrupts gcov data generated by the main C++ and Go tests.
Previously, the coverage job ran the normal test suite and then ran the kvrocks2redis test from the same coverage build. Both
kvrocksandkvrocks2redislinkkvrocks_objs, so they wrote to the same.gcdafiles. This producedlibgcov profiling error: overwriting an existing profile data with a different timestampand could make SonarCloud report some covered files as uncovered.The fix keeps the coverage data isolated:
coverage-main.jsonkvrocks_objsprofilesThis does not add new command coverage by itself. It makes sure coverage produced by existing tests is preserved and merged correctly instead of being overwritten by the kvrocks2redis stage.
Assisted-by: Codex/GPT5.5 xhigh