KNOX-3330: Handle interceptor name collisions#1251
Open
handavid wants to merge 1 commit into
Open
Conversation
Partition IDs are taken from the interceptor names with whitespace removed. This could lead to potential collisions in the Partition IDs. This change adds a numerical suffix in the case of collision to ensure that the Partition IDs are unique. A unit test was added to cover the case where Partition IDs would collide. Unit tests were improved to check that interceptors are created in the expected order (reverse order based on the interceptorNames config). gateway-site.xml examples were moved to doc section.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3330 - Ensure Partition IDs are unique when starting Knox LDAP Proxy.
What changes were proposed in this pull request?
Partition IDs are taken from the interceptor names with whitespace removed. This could lead to potential collisions in the Partition IDs. This change adds a numerical suffix in the case of collision to ensure that the Partition IDs are unique. A unit test was added to cover the case where Partition IDs would collide.
Unit tests were improved to check that interceptors are created in the expected order (reverse order based on the interceptorNames config).
gateway-site.xml examples were moved to doc section.
How was this patch tested?
Unit tests were added to cover the Partition IDs change.
Integration Tests
no changes
UI changes
no changes