Skip to content

MINOR: Remove redundant local variable in KTableSuppressProcessorMetricsTest - #23286

Merged
m1a2st merged 1 commit into
apache:trunkfrom
Mirai1129:MINOR-remove-unused-local-vars-suppress-test
Aug 28, 2026
Merged

MINOR: Remove redundant local variable in KTableSuppressProcessorMetricsTest#23286
m1a2st merged 1 commit into
apache:trunkfrom
Mirai1129:MINOR-remove-unused-local-vars-suppress-test

Conversation

@Mirai1129

@Mirai1129 Mirai1129 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

These local variables are unnecessary — they just re-assign the
class-level *MetricLatest fields with no additional logic, so this
change uses the class-level variables directly instead.

Reviewers: Ken Huang s7133700@gmail.com, yaodehuang sef1548@gmail.com

@github-actions github-actions Bot added triage PRs from the community streams tests Test fixes (including flaky tests) small Small PRs labels Aug 26, 2026
@chia7712 chia7712 added ci-approved and removed small Small PRs labels Aug 26, 2026

@m1a2st m1a2st left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@m1a2st m1a2st changed the title MINOR: remove redundant local variable MINOR: Remove redundant local variable in KTableSuppressProcessorMetricsTest Aug 27, 2026
@github-actions github-actions Bot removed the triage PRs from the community label Aug 27, 2026
@yaodehaung

Copy link
Copy Markdown

LGTM

@m1a2st
m1a2st merged commit 165e04e into apache:trunk Aug 28, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved streams tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants