KAFKA-20940: Windowed changelog restore optimization is skipped whenever a checkpointed offset exists - #23285
Open
alanlau28 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/KAFKA-20940
The windowed changelog restore optimization added in KAFKA-13499, which
seeks past already-expired records instead of restoring them, only ran
for partitions with no checkpointed offset; whenever a checkpoint
existed the reader sought straight to it and restored every record after
it, replaying a prefix of data that retention had already expired. This
extends the optimization to checkpointed active windowed changelogs
whose checkpoint is far enough behind the end offset to be worth it,
running them through the same probe but floored at the checkpoint so
restoration never rewinds past records that have already been applied.
When the probe cannot place a partition, or the checkpoint sits below
the log start or the log is empty, restore falls back to the checkpoint
rather than the beginning and leaves the existing truncation and
corruption handling unchanged.