KAFKA-14218: Replace temp file handler with JUnit 5 @TempDir in connect tests - #23280
Open
KhyatiVaghamshi wants to merge 1 commit into
Open
KAFKA-14218: Replace temp file handler with JUnit 5 @TempDir in connect tests#23280KhyatiVaghamshi wants to merge 1 commit into
KhyatiVaghamshi wants to merge 1 commit into
Conversation
…ct tests Replace File.createTempFile() with JUnit 5 @tempdir annotation in FileStreamSourceTaskTest and FileOffsetBackingStoreTest. This removes the need for manual @AfterEach cleanup methods as JUnit 5 handles temporary directory lifecycle automatically. Generated-by: Claude (Anthropic)
github-actions
Bot
added
triage
Author
|
This addresses KAFKA-14218 with a scoped 2-file change as suggested in the ticket comments. cc @mimaison @showuon for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
File.createTempFile()with JUnit 5@TempDirannotation in two Connect test files:FileStreamSourceTaskTest.java(connect/file module)FileOffsetBackingStoreTest.java(connect/runtime module)This removes the need for manual
@AfterEachcleanup methods as JUnit 5 handles temporary directory lifecycle automatically.Changes
@TempDir private Path tempDirfield to both test classesFile.createTempFile(...)withFiles.createFile(tempDir.resolve(...)).toFile()@AfterEach teardown()methods that manually deleted temp filesScope
This is a scoped PR covering 2 files as suggested in the JIRA ticket comments. Additional files can be migrated in follow-up PRs.
Test plan
FileStreamSourceTaskTest- all tests passFileOffsetBackingStoreTest- all tests pass./gradlew connect:file:test --tests FileStreamSourceTaskTest./gradlew connect:runtime:test --tests FileOffsetBackingStoreTest