Skip to content

KAFKA-20987: Remove hamcrest from org.apache.kafka.streams.processor.internals.metrics package - #23278

Merged
chia7712 merged 1 commit into
apache:trunkfrom
shantanushukla:KAFKA-20987-remove-hamcrest-processor-internals-metrics
Aug 26, 2026
Merged

KAFKA-20987: Remove hamcrest from org.apache.kafka.streams.processor.internals.metrics package#23278
chia7712 merged 1 commit into
apache:trunkfrom
shantanushukla:KAFKA-20987-remove-hamcrest-processor-internals-metrics

Conversation

@shantanushukla

@shantanushukla shantanushukla commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

JIRA: https://issues.apache.org/jira/browse/KAFKA-20987
Parent: https://issues.apache.org/jira/browse/KAFKA-20948

Migrate hamcrest assertThat usage in org.apache.kafka.streams.processor.internals.metrics tests to JUnit 5. This package is not covered by the existing subtasks:

Files changed:

  • ProcessorNodeMetricsTest.java
  • StreamsMetricsImplTest.java
  • TaskMetricsTest.java
  • ThreadMetricsTest.java
  • TopicMetricsTest.java

No production code changes. This contribution is original work and is licensed to the project under the Apache License, Version 2.0.

Tests

./gradlew :streams:test \
  --tests org.apache.kafka.streams.processor.internals.metrics.ProcessorNodeMetricsTest \
  --tests org.apache.kafka.streams.processor.internals.metrics.StreamsMetricsImplTest \
  --tests org.apache.kafka.streams.processor.internals.metrics.TaskMetricsTest \
  --tests org.apache.kafka.streams.processor.internals.metrics.ThreadMetricsTest \
  --tests org.apache.kafka.streams.processor.internals.metrics.TopicMetricsTest \
  :streams:checkstyleTest :streams:spotlessCheck

BUILD SUCCESSFUL.

Reviewers: Chia-Ping Tsai chia7712@gmail.com

Convert hamcrest assertThat usage in
org.apache.kafka.streams.processor.internals.metrics tests to JUnit 5
assertions. No production code changes.
@github-actions github-actions Bot added triage PRs from the community streams tests Test fixes (including flaky tests) labels Aug 26, 2026

@chia7712 chia7712 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712
chia7712 merged commit 313a774 into apache:trunk Aug 26, 2026
22 checks passed
@github-actions github-actions Bot removed the triage PRs from the community label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved streams tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants