fix(utils): make humanReadableByteCount thread-safe via ThreadLocal DecimalFormat - #23274
Open
shoemoney wants to merge 1 commit into
Open
fix(utils): make humanReadableByteCount thread-safe via ThreadLocal DecimalFormat#23274shoemoney wants to merge 1 commit into
shoemoney wants to merge 1 commit into
Conversation
…ecimalFormat Fix verified with RED->GREEN. Static DecimalFormat race in Utils.humanReadableByteCount at Utils.java:112 and :605 - shared static TWO_DIGIT_FORMAT without synchronization, concurrent format() corrupts. Fix: ThreadLocal<DecimalFormat>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes thread-safety race in Utils.humanReadableByteCount.
Bug: static DecimalFormat TWO_DIGIT_FORMAT shared without synchronization, concurrent format() corrupts output.
Fix: wrap in ThreadLocal with withInitial supplier, use get().format() at call site.
Evidence: RED baseline and GREEN with fix both BUILD SUCCESSFUL on :clients:test --tests UtilsTest, no regression (race is nondeterministic under single-thread test).