MINOR: Address suppress HEADERS system test follow-ups - #23269
Open
aliehsaeedii wants to merge 1 commit into
Open
MINOR: Address suppress HEADERS system test follow-ups#23269aliehsaeedii wants to merge 1 commit into
aliehsaeedii wants to merge 1 commit into
Conversation
aliehsaeedii
force-pushed
the
KAFKA-20850-followups
branch
from
August 25, 2026 12:26
9ffc2a9 to
2f946c6
Compare
- Warn against changing the "Restoring apparently invalid changelog record" exception message in InMemoryTimeOrderedKeyValueChangeBuffer, since streams_application_upgrade_test.py greps the logs for it. - Remove the dead "rolling" bounce path in the system test (no test ever set bounce_type="rolling"), along with its only caller do_stop_start_bounce and the now single-valued bounce_type parameter.
aliehsaeedii
force-pushed
the
KAFKA-20850-followups
branch
from
August 25, 2026 12:31
2f946c6 to
c063d92
Compare
mjsax
added
tests
chia7712
reviewed
Aug 26, 2026
chia7712
left a comment
chia7712
left a comment
Member
There was a problem hiding this comment.
overall LGTM except for one small comment. The e2e test passes on my machine
SESSION REPORT (ALL TESTS)
ducktape version: 0.14.0
session_id: 2026-08-26--003
run time: 6 minutes 36.532 seconds
tests run: 21
passed: 21
flaky: 0
failed: 0
ignored: 0
| @matrix(from_version=smoke_test_versions, metadata_quorum=[quorum.combined_kraft]) | ||
| def test_app_upgrade(self, from_version, metadata_quorum): | ||
| """ | ||
| Starts 3 KafkaStreams instances with <old_version>, and upgrades one-by-one to <new_version> |
Member
There was a problem hiding this comment.
Would you mind updating the docstring? The one-by-one is obsolete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the review of #23075:
Warn against changing the "Restoring apparently invalid changelog
record" exception message in InMemoryTimeOrderedKeyValueChangeBuffer,
since streams_application_upgrade_test.py greps the logs for it to
assert that no suppress-changelog record is rejected while restoring
across the HEADERS format boundary.
Remove the dead "rolling" bounce path in
streams_application_upgrade_test.py. No test ever set
bounce_type="rolling" (the matrix has always been ["full"]), so the
branch and its only caller, do_stop_start_bounce, were unreachable. Drop
the now single-valued bounce_type parameter as well.
Reviewers: Matthias J. Sax matthias@confluent.io, Chia-Ping Tsai
chia7712@gmail.com