Skip to content

kafka - 19409: Upgrade RocksDB to 10.5.1 - #21863

Closed
deepgolani4 wants to merge 6 commits into
apache:trunkfrom
deepgolani4:trunk
Closed

kafka - 19409: Upgrade RocksDB to 10.5.1#21863
deepgolani4 wants to merge 6 commits into
apache:trunkfrom
deepgolani4:trunk

Conversation

@deepgolani4

@deepgolani4 deepgolani4 commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

This PR updates:

gradle/dependencies.gradle (rocksDB -> 10.5.1)
LICENSE-binary (rocksdbjni-10.5.1)
Compatibility updates in RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter:

max_write_buffer_number_to_maintain: removed in RocksDB 10.2.1, now handled as deprecated compatibility shim (warn + no-op return).
skip_checking_sst_file_sizes_on_db_open: deprecated in RocksDB 10.5.1, now explicitly marked deprecated and logged when used.
fail_if_options_file_error: kept for API compatibility, marked deprecated with warning since RocksDB 10.2.1+ changed behavior.

diff:
https: //github.com/facebook/rocksdb/compare/v10.1.3...v10.5.1
Reviewers: Matthias J. Sax matthias@confluent.io

@deepgolani4 deepgolani4 changed the title feat: Upgrade RocksDB to 10.5.1 and deprecate options that are remove… kafka - 19409: Upgrade RocksDB to 10.5.1 Mar 25, 2026
@github-actions github-actions Bot added streams dependencies Pull requests that update a dependency file build Gradle build or GitHub Actions small Small PRs labels Apr 2, 2026
@mimaison
mimaison requested a review from mjsax April 16, 2026 10:14
@github-actions

Copy link
Copy Markdown

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions Bot added the stale Stale PRs label Jul 16, 2026
pcollections: "4.0.2",
re2j: "1.8",
rocksDB: "10.1.3",
rocksDB: "10.5.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see newer versions have been published since this PR was raised. Perhaps worth considering a bump to latest?

@mjsax

mjsax commented Aug 13, 2026

Copy link
Copy Markdown
Member

Closing this PR -- we never got to this, and plan to upgrade to 10.10.1+ which was release in the mean time now.

#22998

@mjsax mjsax closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Gradle build or GitHub Actions dependencies Pull requests that update a dependency file small Small PRs stale Stale PRs streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants