Skip to content

OAK-12437: gate ASYNC maintenance and entry metadata together - #3190

Open
rishabhdaim wants to merge 1 commit into
OAK-12425from
issue/OAK-12437
Open

rishabhdaim wants to merge 1 commit into
OAK-12425from
issue/OAK-12437

Conversation

@rishabhdaim

@rishabhdaim rishabhdaim commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Opt explicitly selected DocumentNodeStore caches into ASYNC maintenance only when both the Caffeine feature from #3176 and disabled-by-default FT_OAK-12437 are enabled. Unconfigured caches remain SYNC; changes require recreating the builder/store or restarting the service.

Persistent ASYNC caches use entry-owned metadata. Queued writes skip retired entries, and invalidation waits for executing writes to prevent resurrection. Generation identity is rechecked after disk reads so a concurrent rotation does not suppress migration. FT-off and SYNC retain the parent wrapper and metadata path; non-persistent caches retain raw values and weights. The file format remains compatible.

Validation: 156 targeted tests pass with Java 17, including generation rotation, recursive SYNC diff loaders, all NODE/CHILDREN mode combinations, and non-persistent DOCUMENT behavior. Bundle baseline and license checks pass.

OAK-12437. Depends on #3176; benchmarks follow in #3174.

Co-Authored-By: OpenAI Codex noreply@openai.com

@rishabhdaim
rishabhdaim added this pull request to stack #3191 October 6, 2026 08:37
@rishabhdaim
rishabhdaim force-pushed the issue/OAK-12437 branch 2 times, most recently from 7a2a840 to d63c2e5 Compare October 6, 2026 16:55
@rishabhdaim
rishabhdaim force-pushed the issue/OAK-12437 branch 2 times, most recently from 419dfe0 to b1c9070 Compare October 6, 2026 17:41
@rishabhdaim
rishabhdaim force-pushed the issue/OAK-12437 branch 2 times, most recently from 12bf2a8 to b85f89e Compare October 6, 2026 17:52
@rishabhdaim rishabhdaim changed the title OAK-12437: gate Document async cache maintenance behind FT OAK-12437: gate ASYNC maintenance and entry metadata together Oct 6, 2026
@rishabhdaim
rishabhdaim force-pushed the issue/OAK-12437 branch 3 times, most recently from 14260c7 to e366fc7 Compare October 6, 2026 23:00
@rishabhdaim
rishabhdaim force-pushed the issue/OAK-12437 branch 2 times, most recently from 162f422 to 3f581b0 Compare October 7, 2026 03:57
@rishabhdaim
rishabhdaim force-pushed the issue/OAK-12437 branch 2 times, most recently from 210b1ac to a842ecf Compare October 7, 2026 06:32
@rishabhdaim
rishabhdaim force-pushed the issue/OAK-12437 branch 2 times, most recently from fa135db to 7d955b1 Compare October 7, 2026 09:49
@rishabhdaim rishabhdaim self-assigned this Oct 7, 2026
Co-Authored-By: OpenAI Codex <noreply@openai.com>
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant