Stop snapshot traversal after directory visit failures - #18379
Open
cragkhit wants to merge 1 commit into
Open
Conversation
Stopped recursive snapshot listing when postVisitDirectory reports a traversal failure.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the consensus module’s snapshot directory traversal helper to stop recursive listing when a directory visit finishes with an error (postVisitDirectory receives a non-null IOException), aligning traversal behavior with failure handling already present in visitFileFailed.
Changes:
- Terminate
Files.walkFileTree(...)traversal whenpostVisitDirectoryreports an exception. - Add logging for directory post-visit failures before terminating traversal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
68
to
+72
| public FileVisitResult postVisitDirectory(Path dir, IOException exc) { | ||
| if (exc != null) { | ||
| logger.info(ConsensusMessages.VISIT_FILE_FAILED, dir.toAbsolutePath(), exc); | ||
| return FileVisitResult.TERMINATE; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. We are researchers from Mahidol University, Thailand, and the State University of Ceará, Brazil, working on a research project for improving open-source projects by using the latest accepted answer from Stack Overflow that matched your code snippet. We found this recommendation for improving your code from https://stackoverflow.com/a/18454342.
Note: Our study is approved by the Institutional Review Board of Mahidol University. You can find the participant information sheet explaining this study https://drive.google.com/file/d/1ml5AqrtWQ9pnifTQyTFTcWQmwp6RuPA7/view?usp=sharing.
Proposed change
Stopped recursive snapshot listing when postVisitDirectory reports a traversal failure.