Skip to content

[Fix] Address IoTConsensus retry path Sonar issues #18373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Caideyipi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Fix] Address IoTConsensus retry path Sonar issues #18373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...b-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,9 @@ public class IoTConsensusServerImpl {
// write.
private static final long WRITER_META_PERSIST_MIN_INTERVAL_MS = 1_000L;
private static final Pattern SNAPSHOT_INDEX_PATTEN = Pattern.compile(".*[^\\d](?=(\\d+))");
private static final String WAIT_FOR_PREVIOUS_REQUEST_MESSAGE =
IoTConsensusMessages
.MESSAGE_THE_REQUEST_MUST_WAIT_FOR_THE_PREVIOUS_REQUEST_TO_COMPLETE_470849A7;
private static final PerformanceOverviewMetrics PERFORMANCE_OVERVIEW_METRICS =
PerformanceOverviewMetrics.getInstance();
private final Logger logger = LoggerFactory.getLogger(IoTConsensusServerImpl.class);
Expand Down Expand Up @@ -1373,6 +1376,7 @@ public SyncLogCacheQueue(int sourcePeerId) {
* order in follower the same as the leader. And besides order insurance, we can make the
* deserialization of PlanNode to be concurrent
*/
@SuppressWarnings({"java:S3776", "java:S6541"}) // Keep lock-protected ordering state together.
private TSStatus cacheAndInsertLatestNode(DeserializedBatchIndexedConsensusRequest request) {
logger.debug(
IoTConsensusMessages.CACHE_AND_INSERT_START,
Expand Down Expand Up @@ -1464,9 +1468,7 @@ private TSStatus cacheAndInsertLatestNode(DeserializedBatchIndexedConsensusReque
for (int j = i + 1; j < insertNodes.size(); j++) {
subStatus.add(
RpcUtils.getStatus(
TSStatusCode.WRITE_PROCESS_REJECT,
IoTConsensusMessages
.MESSAGE_THE_REQUEST_MUST_WAIT_FOR_THE_PREVIOUS_REQUEST_TO_COMPLETE_470849A7));
TSStatusCode.WRITE_PROCESS_REJECT, WAIT_FOR_PREVIOUS_REQUEST_MESSAGE));
}
break;
}
Expand Down
Loading