Skip to content

[Performance] Reduce allocations on aligned tablet writes #18358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Caideyipi wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Performance] Reduce allocations on aligned tablet writes #18358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef44ea5
[Performance] Avoid bitmap copies for aligned tablet prefixes
Caideyipi Jul 30, 2026
cde4ef7
[Performance] Defer bitmap allocation for sparse aligned writes
Caideyipi Jul 30, 2026
e04c71a
[Performance] Avoid device collection for single-device aligned tablets
Caideyipi Jul 30, 2026
6254676
Merge remote-tracking branch 'origin/master' into perf/aligned-bitmap…
Caideyipi Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .../apache/iotdb/db/queryengine/plan/planner/plan/node/write/RelationalInsertTabletNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@ public void setSingleDevice() {
this.singleDevice = true;
}

public boolean isSingleDevice() {
return singleDevice;
}

public List<Binary[]> getObjectColumns() {
List<Binary[]> objectColumns = new ArrayList<>();
for (int i = 0;
Expand Down
38 changes: 26 additions & 12 deletions .../src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
import org.apache.iotdb.db.queryengine.plan.planner.plan.node.write.InsertRowsNode;
import org.apache.iotdb.db.queryengine.plan.planner.plan.node.write.InsertTabletNode;
import org.apache.iotdb.db.queryengine.plan.planner.plan.node.write.RelationalDeleteDataNode;
import org.apache.iotdb.db.queryengine.plan.planner.plan.node.write.RelationalInsertTabletNode;
import org.apache.iotdb.db.schemaengine.schemaregion.utils.ResourceByPathUtils;
import org.apache.iotdb.db.service.metrics.WritingMetrics;
import org.apache.iotdb.db.storageengine.dataregion.DataRegion;
Expand Down Expand Up @@ -648,19 +649,8 @@ public void insertTablet(

ensureMemTable(infoForMetrics);
workMemTable.checkDataType(insertTabletNode);
Set<IDeviceID> alignedDeviceIds = new HashSet<>();
if (insertTabletNode.isAligned()) {
for (int[] range : rangeList) {
for (Pair<IDeviceID, Integer> deviceEndPosition :
insertTabletNode.splitByDevice(range[0], range[1])) {
alignedDeviceIds.add(deviceEndPosition.getLeft());
}
}
}
AlignedTVListRamCostSnapshot alignedRamCostSnapshot =
alignedDeviceIds.isEmpty()
? null
: new AlignedTVListRamCostSnapshot(workMemTable, alignedDeviceIds);
takeAlignedTVListRamCostSnapshot(workMemTable, insertTabletNode, rangeList);

long[] memIncrements =
scheduleMemoryBlock(insertTabletNode, rangeList, results, infoForMetrics);
Expand Down Expand Up @@ -1394,6 +1384,30 @@ private void reconcileAlignedTVListRamCost(
}
}

static AlignedTVListRamCostSnapshot takeAlignedTVListRamCostSnapshot(
IMemTable memTable, InsertTabletNode insertTabletNode, List<int[]> rangeList) {
if (!insertTabletNode.isAligned() || rangeList.isEmpty()) {
return null;
}

if (!(insertTabletNode instanceof RelationalInsertTabletNode)
|| ((RelationalInsertTabletNode) insertTabletNode).isSingleDevice()) {
return new AlignedTVListRamCostSnapshot(
memTable, insertTabletNode.getDeviceID(rangeList.get(0)[0]));
}

Set<IDeviceID> alignedDeviceIds = new HashSet<>();
for (int[] range : rangeList) {
for (Pair<IDeviceID, Integer> deviceEndPosition :
insertTabletNode.splitByDevice(range[0], range[1])) {
alignedDeviceIds.add(deviceEndPosition.getLeft());
}
}
return alignedDeviceIds.isEmpty()
? null
: new AlignedTVListRamCostSnapshot(memTable, alignedDeviceIds);
}

static final class AlignedTVListRamCostSnapshot {

private final IMemTable memTable;
Expand Down
Loading
Loading