IGNITE-29034 SQL Calcite: Add support for FROM DUAL queries - #13545
Open
tkalkirill wants to merge 1 commit into
Open
IGNITE-29034 SQL Calcite: Add support for FROM DUAL queries#13545tkalkirill wants to merge 1 commit into
tkalkirill wants to merge 1 commit into
Conversation
vldpyatkov
reviewed
Sep 3, 2026
| if (frameworkCfg != null && frameworkCfg.getParserConfig().conformance().isSupportedDualTable() | ||
| && schema.tables().get(DUAL_TBL_NAME) == null | ||
| && schema.getFunctions(DUAL_TBL_NAME).stream().noneMatch(TableMacro.class::isInstance)) { | ||
| schema.add(DUAL_TBL_NAME, new ViewTableMacroImpl(DUAL_TBL_VIEW, schema, frameworkCfg)); |
Contributor
There was a problem hiding this comment.
I’m not sure whether we really need this, but Calcite supports this property. If we decide to support it, let’s implement it the same way as Calcite does, because its implementation also works with grammars that do not allow SELECT without a FROM clause.
VALUES ('X')
vldpyatkov
reviewed
Sep 3, 2026
|
|
||
| /** */ | ||
| private static void registerDualTableIfSupported(SchemaPlus schema, FrameworkConfig frameworkCfg) { | ||
| if (frameworkCfg != null && frameworkCfg.getParserConfig().conformance().isSupportedDualTable() |
Contributor
There was a problem hiding this comment.
Wouldn't it be more appropriate to use the validator conformance here?
vldpyatkov
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-29034