feat(datafusion): carry catalog identity on StaticTableProvider - #3016
Open
NoahKusaba wants to merge 1 commit into
Open
feat(datafusion): carry catalog identity on StaticTableProvider#3016NoahKusaba wants to merge 1 commit into
NoahKusaba wants to merge 1 commit into
Conversation
Contributor
Author
|
Hey @mbutrovich, following up on the snapshot_id PR you reviewed. As discussed, this lets Do you have time to take a look? I have 3 more follow-up PR's planned that will extend same to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
related to discussion in github.com//pull/2862
IcebergCatalogConfig { type, name, props }, which mirrors inputs toCatalogBuilder::load, as an optional field to StaticTableProvider andIcebergTableScan.IcebergStaticTableProvider::with_catalog_configrecords it;config(),table_ident(), andsnapshot_id()read it back (to recreate the Table struct with new live FileIO).IcebergTableScancarries it into the physical plan, so a scan shipped to a remote worker can rebuild its own storage.Nothing connects using these values. The field is an
Optiondefaulting toNone,so existing constructors are unaffected and the public API change is purely additive.
It lives in
iceberg-datafusionrather thaniceberg-catalog-loaderto avoidpulling the glue/hms/rest/s3tables/sql catalogs in for a three-field struct.
Are these changes tested?
AI Disclosure
CatalogBuilder::load