fix(reader): graceful handling of missing column index#2693
Open
sandugood wants to merge 2 commits into
Open
Conversation
…lection When row_selection_enabled is true and the Parquet file lacks column or offset index metadata (common with older/migrated files), the reader now skips page-level row pruning instead of returning an error. Row-group filtering via statistics and the ArrowPredicate row filter still function normally; only page-index-based RowSelection is skipped. Closes apache#2452
…the new functionality
Author
|
It seems that the original PR didn't receive any feedback from the committer. We keep having the same bug (regarding .parquet reading in Datafusion Comet). That is why I iterated over it and introduced the proposed changes. cc @laskoviymishka, if you have time to review this. Thanks in advance! |
sandugood
changed the title
Contributor
|
I'll take a look on this week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Changed the
get_row_selection_for_filter_predicateto returnOk(None)on cases where indices were absent instead of throwing an error.Are these changes tested?
Unit-tested the change in logic. As specified in the #2464 (comment)