Lazy pagination iterator for catalog list methods#3416
Open
GayathriSrividya wants to merge 1 commit into
Open
Conversation
…che#3365) - Changed list_tables, list_namespaces, list_views return types from list[Identifier] to Iterator[Identifier] in the base Catalog abstract class and all implementations - REST catalog uses true generators with per-page HTTP fetch helpers (decorated with @Retry) to correctly support auth retry logic - Other catalogs (SQL, DynamoDB, Glue, Hive, BigQuery, NoOp) return iter() of their results - CLI and output updated to work with iterators - All test files updated to wrap list_* calls with list() where needed Closes apache#3365
Contributor
|
@GayathriSrividya To credit the original author, it would be good to cherry-pick his work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3365
Changes
list_tables,list_namespaces,list_viewsreturn types fromlist[Identifier]toIterator[Identifier]@retry) to correctly support auth retry logiciter()of their results