Repository navigation
Conversation
- Introduce GraphKey for graph-space and graph-name identity. - Migrate registry and lifecycle tracking to typed keys. - Preserve string boundaries and the live graph-name view. - Add registry regressions and adapt existing lifecycle fixtures.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3482 +/- ##
============================================
+ Coverage 58.52% 58.54% +0.01%
- Complexity 2717 3096 +379
============================================
Files 779 780 +1
Lines 69439 69458 +19
Branches 9577 9582 +5
============================================
+ Hits 40637 40662 +25
+ Misses 25108 25099 -9
- Partials 3694 3697 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: GraphKey replaces every string registry key in GraphManager with matching behaviour under the graph and graph space naming rules, and the 128 focused GraphManager unit tests pass at this head.
imbajin
left a comment
There was a problem hiding this comment.
Score: 8.2/10 · Confidence: medium
Blocking: no
Summary
No new actionable regression confirmed in the typed graph registry conversion.
Evidence
Traced registry creation, lookup, removal and reload, the live names view, metadata string boundaries, and graph-name validation. The latter excludes the delimiter from graph names.
Validation notes
Live PD events and multi-node lifecycle behavior were not independently tested. An older event parser still splits hyphenated graph-space names; an introduced regression was not established. Approval is withheld pending those integration checks.
Purpose of the PR
Address the GraphManager FIXME by replacing combined string keys with typed graph identities.
In
GraphManagerthere is a comment to ask for fix:Main Changes
Verifying these changes
128 focused tests passed, including four new regression tests. Formatting, full clean compilation, and git diff --check passed.
Does this PR potentially affect the following parts?
Documentation Status