[2.4.x] further mod_auth_digest improvements - #738
Open
notroj wants to merge 8 commits into
Open
Conversation
(initialize_module): Correct the description of the client table's lifetime. (note_digest_auth_failure): An unknown client is not necessarily one whose entry was garbage collected. No functional change. [skip ci] Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> GitHub: PR apache#730 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1937709 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit 6f5f7ea)
* modules/aaa/mod_auth_digest.c (initialize_tables): Seed the client ids randomly for each shared memory segment. * test/modules/aaa/test_009_restart.py: New test suite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> GitHub: PR apache#730 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1937711 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit f4c4160)
…e to 8192 bytes, holding around 140 clients. * docs/manual/mod/mod_auth_digest.xml: Document the new default. * test/modules/aaa/conftest.py, test/modules/aaa/test_008_onetime_nccheck.py: Pin AuthDigestShmemSize to the old size. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> GitHub: PR apache#730 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1937712 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit 8e3c9de)
…which have never authenticated before the least recently used. * test/modules/aaa/test_010_eviction.py: New test suite. * test/modules/aaa/test_008_onetime_nccheck.py (085): Fill the table with clients which have authenticated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> GitHub: PR apache#730 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1937713 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit 57968c0)
assignment to client_key which is never read, and the qop variable which only ever holds one string. No functional change. [skip ci] Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> GitHub: PR apache#730 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1937715 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit 0f49205)
* modules/aaa/mod_auth_digest.c (gen_nonce_hash): Use apr_siphash24_auth() where APU 1.6 or later provides it, keeping the SHA-1 hash otherwise. Take a pool for the message buffer, and length-prefix the realm. * test/modules/aaa/test_002_nonce.py (test_digest_021): Take the length of the hash from the nonce rather than assuming SHA-1's. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> GitHub: closes apache#730 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1937716 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit 8be3ef8)
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
positives from embedded passwords in test/modules/aaa. See https://github.com/gitleaks/gitleaks for details. [skip ci] git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1937465 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit c5ec883)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.