HIVE-29709: Add health check to docker#6591
Conversation
abstractdog
left a comment
There was a problem hiding this comment.
very nice improvement @ayushtkn , 2 comments only
| - zookeeper_datalog:/datalog | ||
| - zookeeper_logs:/logs | ||
| healthcheck: | ||
| test: ["CMD-SHELL", "bash -c 'echo ruok > /dev/tcp/localhost/2181'"] |
There was a problem hiding this comment.
for clarity's sake, zookeeper is supposed to return "imok", however this happens after start:
docker compose exec zookeeper sh -c 'printf ruok | nc -w 2 127.0.0.1 2181'
...
ruok is not executed because it is not in the whitelist.
maybe
environment:
ZOO_4LW_COMMANDS_WHITELIST: ruok
I think if the zookeeper is unable to start, then a connection refused is already enough to ensure the unhealthy state, however, it would be good to somehow have "imok" in the response check
| timeout: 3s | ||
| retries: 30 | ||
|
|
||
| tezam: |
There was a problem hiding this comment.
is there a chance to have healthcheck for tezams?
tez.am.rpc.port could be set to a static value, and multiple tez AM's won't collide given they are on different hosts like llap daemons
|



What changes were proposed in this pull request?
Add health check to Hive docker startup
Why are the changes needed?
Better user experiance
Does this PR introduce any user-facing change?
Yes, post hive cluster startup, you need not to wait randomly
How was this patch tested?
Manually
Before
After - Non-LLAP
After - LLAP