Conversation
…er build Add a --jdk 8|17|21 option to build-hbase.sh, passed to the Dockerfiles as the JDK_VERSION build arg. DEFAULT_JDK is 17 on master (8 on branch-2). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
virajjasani
approved these changes
Oct 5, 2026
virajjasani
left a comment
virajjasani
left a comment
Contributor
There was a problem hiding this comment.
Left nits, looks good otherwise
| case "$1" in | ||
| --jdk) | ||
| if [ $# -lt 2 ] || [ -z "$2" ]; then | ||
| echo "❌ ERROR: --jdk requires a value (supported: $SUPPORTED_JDKS)" |
Contributor
There was a problem hiding this comment.
Can we remove cross checkmark from echo?
| set -- "${args[@]+"${args[@]}"}" | ||
|
|
||
| if [[ " $SUPPORTED_JDKS " != *" $JDK_VERSION "* ]]; then | ||
| echo "❌ ERROR: Unsupported JDK version: $JDK_VERSION (supported: $SUPPORTED_JDKS)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er build
Add a --jdk 8|17|21 option to build-hbase.sh, passed to the Dockerfiles as the JDK_VERSION build arg. DEFAULT_JDK is 17 on master (8 on branch-2).