HBASE-30447 Table-level metrics can stop updating until the RegionServer restarts - #8730
Open
d-c-manning wants to merge 2 commits into
Open
d-c-manning wants to merge 2 commits into
d-c-manning wants to merge 2 commits into
Conversation
virajjasani
self-requested a review
October 1, 2026 20:45
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-30447
It is possible for table-level metrics from
MetricsTableWrapperAggregateImpl.javato stop updating, and continually produce the last static value until RegionServer restart.The cause is not known but the most likely result is some type of
NullPointerExceptionin therunmethod.Because an exception is not caught in the
runmethod, theScheduledFutureTaskwill no longer be scheduled after the uncaught exception is thrown.There is no logging, so the cause of us seeing this behavior is not currently known. But with this issue fix, we could have logging to identify the source of the exception, which could lead to other bug fixes.
We didn't have region-level metrics enabled at the time, but since
MetricsRegionWrapperImpl.javahas a similar pattern, I make a similar fix here.MetricsRegionServerWrapperImpl.javaalready has this fix in place, see commit 999ae69 from HBASE-14891Due to the try-catch indentation, the fix is best visualized with ignoring whitespace, i.e. https://github.com/apache/hbase/pull/8730/changes?w=1
Relates to #1729