[GEODE-10612] Pulse region-detail error message does not display the requested region path correctly - #8041
Open
JinwooHwang wants to merge 1 commit into
Open
[GEODE-10612] Pulse region-detail error message does not display the requested region path correctly#8041JinwooHwang wants to merge 1 commit into
JinwooHwang wants to merge 1 commit into
Conversation
When a region-detail request names a path that does not resolve, the region services return "Region [<path>] is not available" in the errorOnRegion field, which the Pulse UI displays. Paths containing characters such as '<' or '&' did not display correctly. Encode the path with StringEscapeUtils.escapeHtml4 when building the message, so it displays as written. commons-text is already a compile dependency of geode-pulse. Region lookup is unchanged and continues to use the path as supplied. Adds RegionErrorMessageEncodingTest and RegionDetailErrorMessageIntegrationTest. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a region-detail request names a path that does not resolve, the region services return "Region [] is not available" in the errorOnRegion field, which the Pulse UI displays. Paths containing characters such as '<' or '&' did not display correctly.
Encode the path with StringEscapeUtils.escapeHtml4 when building the message, so it displays as written. commons-text is already a compile dependency of geode-pulse.
Region lookup is unchanged and continues to use the path as supplied.
Adds RegionErrorMessageEncodingTest and
RegionDetailErrorMessageIntegrationTest.
For all changes, please confirm:
develop)?gradlew buildrun cleanly?