[lake] Reset lake filters for each pushdown#3414
Open
QuakeWang wants to merge 1 commit into
Open
Conversation
Lake sources kept filter pushdown predicates as mutable instance state. When a later pushdown had no convertible predicates, the old lake predicate could still be used by split planning and reading. Reset Paimon and Iceberg filters on each pushdown, clear lake filters from Flink when no lake predicate is convertible, and replay lake pushdown state onto an independent lake source when Flink copies the table source. Add regression coverage for Paimon, Iceberg, and Flink lake source copy isolation.
Author
|
@luoyuxia PTAL, Thanks : ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Lake filter pushdown state was kept on mutable lake source instances. If a later pushdown had no convertible lake predicates, the old predicate could remain active and incorrectly filter subsequent lake reads.
Brief change log
withFilterscall.FlinkTableSource, avoiding shared mutable lake source state between copies.Tests
./mvnw -pl fluss-flink/fluss-flink-common -am -Dtest='FlinkTableSourceFilterPushDownTest$LakeSourcePushDownTests' -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false test./mvnw -pl fluss-flink/fluss-flink-common,fluss-lake/fluss-lake-paimon,fluss-lake/fluss-lake-iceberg -am -Dtest=FlinkTableSourceFilterPushDownTest,PaimonLakeSourceTest,IcebergLakeSourceTest -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false testAPI and Format
Documentation