Skip to content

[flink] Fail fast on batch virtual log table reads#3402

Open
QuakeWang wants to merge 1 commit into
apache:mainfrom
QuakeWang:fix-3144
Open

[flink] Fail fast on batch virtual log table reads#3402
QuakeWang wants to merge 1 commit into
apache:mainfrom
QuakeWang:fix-3144

Conversation

@QuakeWang
Copy link
Copy Markdown

Purpose

Linked issue: close #3144

Batch reads on $binlog and $changelog virtual tables could pass source creation and fail later in the source coordinator with an internal lake-source error. These virtual log tables are currently log-only and only support streaming mode.

Brief change log

  • Reject batch runtime mode in $binlog and $changelog table source creation.
  • Return a clear UnsupportedOperationException before job submission.
  • Add factory and planner-path tests for both virtual table types.

Tests

  • mvn -B -ntp -Dskip.on.java8=true -DfailIfNoTests=false -pl fluss-flink/fluss-flink-1.20 -am -Dtest=Flink120TableFactoryTest test
  • mvn -B -ntp -Dskip.on.java8=true -DfailIfNoTests=false -pl fluss-flink/fluss-flink-1.20 -am -Dtest=Flink120BinlogVirtualTableITCase,Flink120ChangelogVirtualTableITCase test

API and Format

Documentation

Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Copy link
Copy Markdown
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @loserwang1024 Could you please have another look

Copy link
Copy Markdown
Contributor

@loserwang1024 loserwang1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Batch reads on / fail with coordinator NPE instead of a clear unsupported error

3 participants