[FLINK-40453][postgres] Not load table schema when initializing record emitter - #4513
Open
naivedogger wants to merge 1 commit into
Open
[FLINK-40453][postgres] Not load table schema when initializing record emitter#4513naivedogger wants to merge 1 commit into
naivedogger wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fixes FLINK-40453.
PostgresPipelineRecordEmittercurrently builds allCreateTableEvents eagerly in its constructor (and again in theapplySplit()override), which opens a JDBC connection and fetches every captured table's schema up front — before any split is processed. This adds startup overhead that scales with the number of captured tables. A table's schema is only needed when its first record / low-watermark / schema-change event is emitted, so loading everything at initialization is wasteful.Brief change log
generateCreateTableEvent()call from the constructor and drop theapplySplit()override that pre-populates the cache.CreateTableEventlazily on demand, falling back to a JDBC lookup only when the split state does not already carry the table schema.Verifying this change
This change added tests and can be verified as follows:
PostgresPipelineRecordEmitterTest, asserting that constructing the emitter opens no JDBC connection and that assigning a snapshot split does not trigger loading of all table schemas.Documentation