Skip to content

FINERACT-2733: add optional payment details to transfer transactions - #6219

Merged
IOhacker merged 1 commit into
apache:developfrom
AnvayKharb:fix/FINERACT-2733-transfer-payment-details
Aug 5, 2026
Merged

FINERACT-2733: add optional payment details to transfer transactions#6219
IOhacker merged 1 commit into
apache:developfrom
AnvayKharb:fix/FINERACT-2733-transfer-payment-details

Conversation

@AnvayKharb

@AnvayKharb AnvayKharb commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Description

Adds optional Payment Detail support to Account Transfer Transactions while preserving backward compatibility.

Transfer transactions can now reference the existing Fineract Payment Detail model when payment information is provided. Existing transfer requests without payment details continue to work without modification.

Changes

  • Added optional PaymentDetail support to account transfer transactions.
  • Linked transfer transactions to PaymentDetail through a nullable database relationship.
  • Updated the transfer creation flow to persist and associate payment details when supplied.
  • Reused the existing Payment Detail infrastructure without introducing duplicate logic.
  • Extended transfer responses to include payment details when available.
  • Added a forward-only Liquibase migration.
  • Added and updated tests covering transfers with and without payment details.

Backward Compatibility

  • Payment details remain optional.
  • Existing transfer requests continue to work unchanged.
  • Existing transfer records remain valid without migration of historical data.

Related Issue

FINERACT-2733

Checklist

  • Payment details are optional.
  • Existing transfer functionality remains unchanged.
  • Backward compatibility is preserved.
  • Database migration is forward-only.
  • Tests added/updated for the new functionality.
  • No unrelated changes included.

@AnvayKharb
AnvayKharb force-pushed the fix/FINERACT-2733-transfer-payment-details branch from 838b98d to 7821a09 Compare August 3, 2026 16:10
@AnvayKharb
AnvayKharb force-pushed the fix/FINERACT-2733-transfer-payment-details branch from 7821a09 to 0541e6b Compare August 3, 2026 17:17
@AnvayKharb

Copy link
Copy Markdown
Contributor Author

@IOhacker i tried to fix this can you please review again

@AnvayKharb
AnvayKharb requested a review from IOhacker August 3, 2026 17:18
@AnvayKharb AnvayKharb changed the title feat(FINERACT-2733): add optional payment details to transfer transactions FINERACT-2733: add optional payment details to transfer transactions Aug 3, 2026
@AnvayKharb
AnvayKharb force-pushed the fix/FINERACT-2733-transfer-payment-details branch from 0541e6b to 7a8825a Compare August 3, 2026 18:44
@IOhacker

IOhacker commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@AnvayKharb please sign the commit

@AnvayKharb
AnvayKharb force-pushed the fix/FINERACT-2733-transfer-payment-details branch from 7a8825a to 22f6e45 Compare August 4, 2026 09:29
@AnvayKharb

Copy link
Copy Markdown
Contributor Author

@IOhacker please review again

@AnvayKharb
AnvayKharb force-pushed the fix/FINERACT-2733-transfer-payment-details branch from 22f6e45 to 0bd0721 Compare August 4, 2026 13:24

@IOhacker IOhacker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IOhacker
IOhacker requested a review from Aman-Mittal August 4, 2026 14:29

@IOhacker IOhacker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IOhacker
IOhacker merged commit 2268b99 into apache:develop Aug 5, 2026
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants