Feature xml xxe prevention#512
Open
sahvx655-wq wants to merge 1 commit into
Open
Conversation
sahvx655-wq
force-pushed
the
feature-xml-xxe-prevention
branch
from
98e3f12 to
3b69bd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens XML parsing across Apache Felix by disabling DTD processing, external entity resolution, and XInclude support in SAX, DOM, StAX, and XMLReader implementations used by core components, libraries, and build tools.
Parser Hardening:Secured XML parser factories in Declarative Services (SCR), iPOJO Manipulator, OSGi Check Maven Plugin, and StAX parsers.
XXE Validation: Added
testParserRejectsXXEinXmlHandlerTestto verify that XML containing external entities or DOCTYPE declarations is safely rejected.Compatibility: Existing OSGi descriptors do not rely on DTDs or external entities, so the changes are expected to be backward-compatible.