test: fix flaky test EmbeddedDartReportApiTest - #19905
Draft
FrankChen021 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The master CI failure was reported as
expected: not <null>atEmbeddedDartReportApiTest.java:348, which is the assertion thatDartQueryInfo.getDurationMs()is non-null. The report response itself was present.The SQL result can be returned before
ControllerHolder.runAsyncfinishes deregistration andDartControllerRegistrypublishes the retained completed report. During that window, the report API can return the running-query snapshot, whosedurationMsis explicitly null. Cross-broker forwarding can observe the same intermediate state.Evidence:
Fix
Poll the report API until each requested broker returns a report with non-null
durationMs, using one shared timeout for the multi-broker check. This synchronizes the test with the API's completed-report state without adding a fixed sleep.Validation
Result: 7 tests passed, 0 failures, 0 errors.