feat: segment availability improvements - #19889
Open
jtuglu1 wants to merge 1 commit into
Open
Conversation
jtuglu1
force-pushed
the
fix-segment-move-replica-accounting-18764
branch
3 times, most recently
from
August 6, 2026 03:10
9877c77 to
7d16389
Compare
jtuglu1
marked this pull request as ready for review
August 6, 2026 15:18
jtuglu1
force-pushed
the
fix-segment-move-replica-accounting-18764
branch
from
August 6, 2026 15:53
7d16389 to
dae9817
Compare
jtuglu1
force-pushed
the
fix-segment-move-replica-accounting-18764
branch
from
August 6, 2026 18:56
dae9817 to
effefb7
Compare
jtuglu1
force-pushed
the
fix-segment-move-replica-accounting-18764
branch
from
August 6, 2026 21:46
effefb7 to
3e1dca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18764.
Description
During move of a 1x-replicated segment from historical A to historical B, the coordinator can currently race and drop a segment temporarily from the timeline.
This occurs through 2 primary ways:
SegmentLoadQueueManager.moveSegmentoperation callsunmarkSegmentToDropand thendropSegmentwhich can race with readers.ServerInventoryView) and historical node callbacks (HttpLoadQueuePeon). Since these historical callbacks typically always arrive first, the code sums up load data from both sources and then does a diff. While this works if the HttpLoadQueuePeon is present in the queue (to cancel out the new pending load on historical B), before this fix, the peon deletes the holder the moment the server acks. So the DROP left the queue while the inventory still showed the segment loaded.Changes
SegmentMoveConcurrencyTest::testMarkToDropGraduatesToQueuedDrop).Release note
This PR has: