Skip to content

docs: require JUnit 5 for new tests in AGENTS.md - #19874

Draft
FrankChen021 wants to merge 2 commits into
apache:masterfrom
FrankChen021:codex/document-junit5-testing-guidance
Draft

docs: require JUnit 5 for new tests in AGENTS.md#19874
FrankChen021 wants to merge 2 commits into
apache:masterfrom
FrankChen021:codex/document-junit5-testing-guidance

Conversation

@FrankChen021

@FrankChen021 FrankChen021 commented Aug 4, 2026

Copy link
Copy Markdown
Member

Description

Update AGENTS.md to require JUnit 5 (org.junit.jupiter) for new test cases and tell coding agents not to add new tests using JUnit 4 (org.junit).

Motivation

This follows review feedback on PR #19826 asking that new tests use JUnit 5 and the follow-up discussion proposing that the rule be documented in AGENTS.md.

The repository-wide migration is tracked by #13948: JUnit4 to JUnit5 migration, which proposes migrating incrementally while retaining JUnit Vintage for backward compatibility. Completing that migration may take time because legacy JUnit 4 tests remain across many modules. In the meantime, this guidance prevents new tests from adding to the remaining migration work. It does not affect Druid runtime behavior.

Verification

  • Confirmed that JUnit 5 is configured across Druid modules.
  • Self-reviewed the complete diff against the target branch.
  • Ran git diff --check.
  • No runtime tests were run because this change only updates agent guidance.

This PR has:

  • been self-reviewed.
  • added documentation for a repository testing requirement.

@FrankChen021 FrankChen021 changed the title docs: require JUnit 5 for new tests docs: require JUnit 5 for new tests in AGENTS.md Aug 4, 2026

@FrankChen021 FrankChen021 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity Findings
P0 0
P1 0
P2 1
P3 0
Total 1
Severity Findings
P0 0
P1 0
P2 1
P3 0
Total 1

Reviewed 1 of 1 changed files.


This is an automated review by Codex GPT-5.6-Sol

Comment thread AGENTS.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant