docs: require JUnit 5 for new tests in AGENTS.md - #19874
Draft
FrankChen021 wants to merge 2 commits into
Draft
Conversation
FrankChen021
commented
Aug 4, 2026
FrankChen021
left a comment
Member
Author
There was a problem hiding this comment.
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 0 |
| P2 | 1 |
| P3 | 0 |
| Total | 1 |
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 0 |
| P2 | 1 |
| P3 | 0 |
| Total | 1 |
Reviewed 1 of 1 changed files.
This is an automated review by Codex GPT-5.6-Sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
AGENTS.mdto require JUnit 5 (org.junit.jupiter) for new test cases and tell coding agents not to add new tests using JUnit 4 (org.junit).Motivation
This follows review feedback on PR #19826 asking that new tests use JUnit 5 and the follow-up discussion proposing that the rule be documented in
AGENTS.md.The repository-wide migration is tracked by #13948: JUnit4 to JUnit5 migration, which proposes migrating incrementally while retaining JUnit Vintage for backward compatibility. Completing that migration may take time because legacy JUnit 4 tests remain across many modules. In the meantime, this guidance prevents new tests from adding to the remaining migration work. It does not affect Druid runtime behavior.
Verification
git diff --check.This PR has: