[improvement](ci) Harden Litefuse OTLP reliability - #67416
Draft
shuke987 wants to merge 2 commits into
Draft
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Litefuse 26.2 rejects legacy trace-create, span-create, and generation-create events on /api/public/ingestion, so code review traces stopped after August 28 even though the review workflow stayed green. Convert the existing review event model to OTLP/HTTP JSON spans, send it to /api/public/otel/v1/traces with ingestion version 4, preserve hierarchy and Langfuse attributes, keep payload chunking, and surface response details for rejected requests.
### Release note
None
### Check List (For Author)
- Test: Unit Test / Manual test
- python3 .github/scripts/test_emit_litefuse_otel_io.py
- Live Litefuse OTLP canary write and read-back verification
- Behavior changed: No. This restores code review observability without changing review decisions.
- Does this need documentation: No
### What problem does this PR solve? Issue Number: None Related PR: apache#67413 Problem Summary: The minimal OTLP migration restores Litefuse trace writes, but large reviews and transient failures still need stronger reliability guarantees. Make legacy pre-chunking linear for multi-thousand-observation traces, retry OTLP-defined transient HTTP failures, paginate v2 observation read-back, and require the full expected set of unique observation IDs before verification succeeds. ### Release note None ### Check List (For Author) - Test: Unit Test - python3 .github/scripts/test_emit_litefuse_otel_io.py - 500 randomized payload and chunk-limit cases - Behavior changed: No. This only strengthens trace transport and verification. - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
shuke987
added a commit
to shuke987/doris
that referenced
this pull request
Sep 2, 2026
### What problem does this PR solve? Issue Number: None Related PR: apache#67416 Problem Summary: Preserve the actual subagent task on the root OTLP observation, avoid truncating spans that fit the full request limit during pre-chunking, and retry singleton HTTP 413 responses against a strictly smaller complete OTLP envelope instead of an arbitrary half-size ceiling. ### Release note None ### Check List (For Author) - Test: Unit Test - python3 .github/scripts/test_emit_litefuse_otel_io.py (11 tests passed) - 200 randomized OTLP chunk cases - Behavior changed: Yes. OTLP trace export now preserves valid payload data and recovers viable singleton 413 requests. - Does this need documentation: No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?\n\nIssue Number: None\n\nRelated PR: #67413\n\nProblem Summary:\n\nThis is a reliability follow-up stacked on #67413. The minimal OTLP migration restores Litefuse trace writes; this separate change hardens large-review transport and read-back verification without expanding the core fix.\n\nThe follow-up makes legacy pre-chunk size accounting linear for multi-thousand-observation traces, retries OTLP-defined transient HTTP failures, paginates the v2 Observations API, prefers v2 read-back with the legacy API as fallback, and requires the complete expected set of unique observation IDs before verification succeeds.\n\nThis PR is intentionally draft while #67413 is open. Its current diff includes the parent OTLP migration commit; after #67413 merges, the remaining diff will be the single reliability commit b8cb66a.\n\n### Release note\n\nNone\n\n### Check List (For Author)\n\n- Test: Unit Test\n - python3 .github/scripts/test_emit_litefuse_otel_io.py (15 tests passed)\n - 500 randomized payload and chunk-limit cases preserved order, count, and exact encoded sizes\n - A 5,220-observation synthetic pre-chunk test preserved every event within the configured request limit\n- Behavior changed: No. This only strengthens Litefuse transport and verification.\n- Does this need documentation: No