[fix](fe) Infer compression before skipping empty schema files - #67412
Open
0AyanamiRei wants to merge 1 commit into
Open
[fix](fe) Infer compression before skipping empty schema files#674120AyanamiRei wants to merge 1 commit into
0AyanamiRei wants to merge 1 commit into
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Schema inference skips empty compressed CSV and JSON files using format-specific minimum sizes, but the check used only the explicitly configured compression type. With the default UNKNOWN type, an empty gzip file selected by a glob was treated as non-empty and prevented a later valid file from supplying the schema. Reuse the existing path-based compression inference before applying the empty-content threshold.
### Release note
File table-valued functions now skip empty gzip CSV and JSON files during schema inference when compression is inferred from the path.
### Check List (For Author)
- Test: Regression test and manual test
- Regression test: test_empty_first_compressed_schema for CSV and JSON gzip globs
- Manual test: local CSV and JSON DESC FUNCTION and queries returned the later valid file rows
- Behavior changed: Yes. Empty compressed files no longer block schema inference for a matching glob.
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 16727 ms |
Contributor
TPC-DS: Total hot run time: 81274 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Schema inference skips empty compressed CSV and JSON files using format-specific minimum sizes, but the check used only the explicitly configured compression type. With the default
UNKNOWNtype, an empty gzip file selected by a glob was treated as non-empty and prevented a later valid file from supplying the schema. Reuse the existing path-based compression inference before applying the empty-content threshold.Release note
File table-valued functions now skip empty gzip CSV and JSON files during schema inference when compression is inferred from the path.
Check List (For Author)
test_empty_first_compressed_schemafor CSV and JSON gzip globsDESC FUNCTIONand queries returned the later valid file rows