[fix](fe) Reject path partition keys for http_stream - #67409
Open
0AyanamiRei wants to merge 1 commit into
Open
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: http_stream accepted path_partition_keys even though streamed request bodies have no file path from which to derive partition values. The invalid property reached backend execution and failed after planning. Reject it while constructing the table-valued function so clients receive a clear analysis error before a transaction is created.
### Release note
http_stream now rejects the unsupported path_partition_keys property during analysis.
### Check List (For Author)
- Test: FE unit test, regression test, and manual HTTP stream test
- FE unit test: HttpStreamTableValuedFunctionTest
- Regression test: test_http_stream_path_partition_keys
- Manual test: control load succeeded with 10 rows; unsupported property returned ANALYSIS_ERROR
- Behavior changed: Yes. An unsupported property is now rejected before execution.
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 16834 ms |
Contributor
TPC-DS: Total hot run time: 82329 ms |
Contributor
ClickBench: Total hot run time: 14.54 s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
http_streamacceptedpath_partition_keyseven though streamed request bodies have no file path from which to derive partition values. The invalid property reached backend execution and failed after planning. Reject it while constructing the table-valued function so clients receive a clear analysis error before a transaction is created.Release note
http_streamnow rejects the unsupportedpath_partition_keysproperty during analysis.Check List (For Author)
HttpStreamTableValuedFunctionTesttest_http_stream_path_partition_keysANALYSIS_ERROR