[fix](test) Align two UT assertions with current master behavior - #67404
[fix](test) Align two UT assertions with current master behavior#67404bosswnx wants to merge 1 commit into
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
IcebergWritePlanProviderTest asserts baseSnapshotId == null for an explicitly pinned empty read, but apache#66348 intentionally changed this to keep the pinned -1 as an OCC fence; the test from apache#66345 was not updated. PropertyAnalyzerTest expects the partition-level "only supports V2, V3 and SNII" message for V1, but apache#64522 already throws the "deprecated" message inside analyzeInvertedIndexFileStorageFormat before the partition-level check can run, making the expected branch unreachable. Update the Iceberg assertion to expect -1 (matching the intent documented in apache#66348), and accept either V1-rejection message in the PropertyAnalyzer assertion. Test-only, no production code changed.
ab02e29 to
f4a5e3f
Compare
|
run buildall |
|
/review |
TPC-H: Total hot run time: 16927 ms |
TPC-DS: Total hot run time: 82557 ms |
ClickBench: Total hot run time: 14.76 s |
FE Regression Coverage ReportIncrement line coverage |
|
The NonConcurrent Regression failure on this PR is not caused by this change — it is a pre-existing BE crash on master, now tracked in #67428. Evidence:
The cascade of ~49 suite failures is downstream of the BE exit ("available backend num is 0"), not separate issues. Given the above, the NonConcurrent pipeline should fail for any PR based on current master. A re-run will hit the same crash until the upstream fix in #67428 lands — happy to help there. Everything else on this PR is green: FE UT pass, CheckStyle pass, P0 Regression pass, External Regression pass. |
What problem does this PR solve?
Issue Number: close #67403
Related PR: #66345 #66348 #64522 #66475
Problem Summary:
Two FE unit tests fail on current master because their assertions contradict behavior that later PRs deliberately introduced:
IcebergWritePlanProviderTest.planMergePreservesExplicitlyEmptyReadAcrossConcurrentFirstAppendassertsbaseSnapshotId == nullfor an explicitly pinned empty read, but [fix](iceberg) Harden external-write lifecycle, OCC, memory, and file ownership #66348 intentionally changed this to keep the pinned-1as an OCC fence (documented inIcebergConnectorTransaction.applyBeginGuards). The test from [fix](iceberg) Fix MVCC and nested schema evolution edge cases #66345 was not updated, so it has been failing since [fix](iceberg) Harden external-write lifecycle, OCC, memory, and file ownership #66348 landed.PropertyAnalyzerTest.testAnalyzePartitionInvertedIndexFileStorageFormatexpects the partition-level message "only supports V2, V3 and SNII" forV1, but [fix](fe) block inverted index V1 creation in FE #64522 already throws the "deprecated" message insideanalyzeInvertedIndexFileStorageFormatbefore the partition-level check can run, making the expected branch unreachable.What changed?
Test-only changes, no production code:
assertEquals(Long.valueOf(-1L), ...)matching the intent documented in [fix](iceberg) Harden external-write lifecycle, OCC, memory, and file ownership #66348, with a comment explaining the semantics.Both tests pass locally after the change:
IcebergWritePlanProviderTest79/79,PropertyAnalyzerTest20/20.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?