Skip to content

[fix](be) Fix macOS BE compilation errors #65783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morningman wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

[fix](be) Fix macOS BE compilation errors #65783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions be/src/common/phdr_cache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,7 @@ class ScopedPHDRCacheRead {
ScopedPHDRCacheRead& operator=(const ScopedPHDRCacheRead&) = delete;

private:
#if defined(__linux__) && !defined(THREAD_SANITIZER) && !defined(USE_MUSL)
bool _previous = false;
#endif
};
4 changes: 2 additions & 2 deletions be/src/format_v2/parquet/parquet_statistics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,8 +1046,8 @@ bool set_page_decoded_min_max(const std::shared_ptr<::parquet::ColumnIndex>& col
page_idx >= typed_index->max_values().size()) {
return false;
}
const auto& min_value = typed_index->min_values()[page_idx];
const auto& max_value = typed_index->max_values()[page_idx];
const typename ParquetDType::c_type min_value = typed_index->min_values()[page_idx];
const typename ParquetDType::c_type max_value = typed_index->max_values()[page_idx];
if constexpr (std::is_same_v<ParquetDType, ::parquet::Int64Type>) {
if (!timestamp_min_max_is_safe(column_schema, min_value, max_value, timezone)) {
return false;
Expand Down
Loading