Skip to content

DRAFT Bench2 26190 - #27153

Draft
kosiew wants to merge 3 commits into
apache:mainfrom
kosiew:bench2-26190
Draft

DRAFT Bench2 26190#27153
kosiew wants to merge 3 commits into
apache:mainfrom
kosiew:bench2-26190

Conversation

@kosiew

@kosiew kosiew commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

BENCH 26190

ole-baranov and others added 3 commits November 5, 2026 17:45
@ole-baranov @claude
bench(substrait): add consume_wide_read benchmark
1b0f202 
Measure Substrait consumption of `SELECT c0` over a table with 100, 1000
and 10000 columns, to track the cost of ReadRel schema handling on wide
tables.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kosiew
feat(substrait): add required-features = ["protoc"] to consume_wide_read
b1e1a62 
- Added `required-features = ["protoc"]` to the `consume_wide_read` configuration in `datafusion/substrait/Cargo.toml`.
- Ensures the `protoc` dependency is properly resolved when building the substrait parser, preventing missing‑feature errors during compilation.
@ole-baranov @claude @kosiew
perf(substrait): avoid quadratic field lookup when consuming ReadRel
ea42f93 
`ensure_schema_compatibility` and `apply_projection` looked up every field
of the Substrait base schema with a linear scan of the table schema, making
consumption of a read over a wide table O(m*n). Build a name->index map of
the table schema once instead. Missing or duplicated names fall back to the
existing DFSchema lookups, so errors and disambiguation are unchanged.

Consume time for `SELECT c0` over a table with N columns
(`consume_wide_read` benchmark):

    columns   before     after
    100       58 us      25.5 us
    1000      2.33 ms    276 us
    10000     211 ms     3.16 ms

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kosiew

kosiew commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

run benchmark consume_wide_read

baseline:
  ref: b1e1a620ed

@github-actions github-actions Bot added the substrait Changes to the substrait crate label Nov 6, 2026
@adriangbot

adriangbot commented Nov 6, 2026

Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c6676490351-4544-nfw6s 6.12.105+ #1 SMP Sat Sep 19 07:55:25 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu) 
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing bench2-26190 (ea42f93) to b1e1a62 diff

Run configuration 
run benchmark consume_wide_read
baseline:
  ref: "b1e1a620ed"

Results will be posted here when complete

File an issue against this benchmark runner

@adriangbot

adriangbot commented Nov 6, 2026

Copy link
Copy Markdown

🤖 Benchmark completed (GKE) | trigger

Instance: c4a-highmem-16 (12 vCPU / 65 GiB)

Comparing bench2-26190 (ea42f93) to b1e1a62 diff

Run configuration 
run benchmark consume_wide_read
baseline:
  ref: "b1e1a620ed"
CPU Details (lscpu) 
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected
Details 

group                      HEAD                                   bench2-26190
-----                      ----                                   ------------
consume_wide_read/100      1.00     32.1±0.24µs        ? ?/sec    1.03     33.2±0.31µs        ? ?/sec
consume_wide_read/1000     1.00    437.5±3.01µs        ? ?/sec    1.03    449.1±3.30µs        ? ?/sec
consume_wide_read/10000    1.00      5.2±0.02ms        ? ?/sec    1.05      5.4±0.03ms        ? ?/sec

Resource Usage

consume_wide_read — base (merge-base)

Metric Value
Wall time 530.1s
Peak memory 89.3 MiB
Avg memory 11.8 MiB
CPU user 34.9s
CPU sys 0.7s
Peak spill 0 B

consume_wide_read — branch

Metric Value
Wall time 520.1s
Peak memory 67.1 MiB
Avg memory 12.0 MiB
CPU user 36.6s
CPU sys 0.4s
Peak spill 0 B

File an issue against this benchmark runner

@kosiew

kosiew commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

run benchmark consume_wide_read

baseline:
  ref: b1e1a620ed

@adriangbot

adriangbot commented Nov 6, 2026

Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c6676785238-4552-487zb 6.12.105+ #1 SMP Sat Sep 19 07:55:25 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu) 
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing bench2-26190 (ea42f93) to b1e1a62 diff

Run configuration 
run benchmark consume_wide_read
baseline:
  ref: "b1e1a620ed"

Results will be posted here when complete

File an issue against this benchmark runner

@adriangbot

adriangbot commented Nov 6, 2026

Copy link
Copy Markdown

🤖 Benchmark completed (GKE) | trigger

Instance: c4a-highmem-16 (12 vCPU / 65 GiB)

Comparing bench2-26190 (ea42f93) to b1e1a62 diff

Run configuration 
run benchmark consume_wide_read
baseline:
  ref: "b1e1a620ed"
CPU Details (lscpu) 
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected
Details 

group                      HEAD                                   bench2-26190
-----                      ----                                   ------------
consume_wide_read/100      1.00     32.0±0.50µs        ? ?/sec    1.03     33.0±0.09µs        ? ?/sec
consume_wide_read/1000     1.00    437.0±1.84µs        ? ?/sec    1.02    445.1±1.97µs        ? ?/sec
consume_wide_read/10000    1.00      5.1±0.02ms        ? ?/sec    1.05      5.4±0.02ms        ? ?/sec

Resource Usage

consume_wide_read — base (merge-base)

Metric Value
Wall time 305.1s
Peak memory 67.1 MiB
Avg memory 15.8 MiB
CPU user 35.2s
CPU sys 0.8s
Peak spill 0 B

consume_wide_read — branch

Metric Value
Wall time 300.1s
Peak memory 89.3 MiB
Avg memory 16.5 MiB
CPU user 36.3s
CPU sys 0.6s
Peak spill 0 B

File an issue against this benchmark runner

@kosiew kosiew mentioned this pull request Nov 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

substrait Changes to the substrait crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kosiew @adriangbot @ole-baranov