Repository navigation
fix: avoid lpad/rpad panic on out-of-range length arrays - #26958
Open
gonappuccino wants to merge 2 commits into
Open
gonappuccino wants to merge 2 commits into
gonappuccino wants to merge 2 commits into
Conversation
github-actions
Bot
added
sqllogictest
mbutrovich
self-requested a review
November 5, 2026 19:17
mbutrovich
requested changes
Nov 5, 2026
mbutrovich
left a comment
mbutrovich
left a comment
Contributor
There was a problem hiding this comment.
Thanks @gonappuccino for picking this up. Skipping the lengths that parse_target_len turns into "" or an error makes the array path agree with the scalar path, which is what #26949 asks for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fork CI setup: For pull requests from a fork to
main, enable workflows in your fork's Actions tab before you push.See the fork CI setup guide.
Which issue does this PR close?
lpadandrpadpanic or abort on a negative or very large length in an array of lengths #26949.Rationale for this change
lpad/rpadpanic or abort when an array length is negative or very large, while a scalar length returns""or the "too large" error.What changes are included in this PR?
pad_data_capacityskips lengths outside0..=i32::MAXand caps the total ati32::MAX. Per-row validation is unchanged.What is the testing strategy for this PR?
Unit tests in
lpad.rs/rpad.rsand sqllogictest cases instring_literal.sltcover negative and very large array lengths.Are there any user-facing changes?
No.