Repository navigation
test: pin parquet created_by in tests so expected output is independent of the version string - #26892
Merged
Merged
Conversation
…the version string The default created_by embeds the DataFusion version, so a longer version string (e.g. 56.0.0-dev) changes the size of every written parquet file, which shifts byte based metrics (scan_efficiency_ratio, file_groups byte ranges, file_size_bytes) in sqllogictest and datafusion-cli expectations. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit 90d3b42)
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
github-actions
Bot
removed
the
development-process
alamb
marked this pull request as ready for review
October 29, 2026 19:20
mbutrovich
approved these changes
Oct 29, 2026
mbutrovich
left a comment
mbutrovich
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me, thanks @alamb!
Contributor
Author
|
Thank you for the quick review @mbutrovich |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
56.0.0(Oct/Nov 2026) #2446156.0.0-dev, document release versioning scheme #26845Rationale for this change
While testing a
56.0.0-devversion onmainin #26845, CI failed because the defaultdatafusion.execution.parquet.created_byvalue (datafusion version 55.1.0) is written into every Parquet file, so changing the version string changes the size of every Parquet file written during tests.Since this happens any time the version string changes, let's just hard code it into the tests that don't matter
What changes are included in this PR?
Hard code a version in tests that don't need it
What is the testing strategy for this PR?
Existing CI.
Are there any user-facing changes?
No, test only.