Repository navigation
test: reuse null-aware join fuzz reference results - #26838
Merged
adriangb merged 2 commits intoNov 6, 2026
Merged
Conversation
Contributor
|
@bvolpato let me know when this is ready for reviewe |
bvolpato
force-pushed
the
bvolpato/cache-null-aware-fuzz-reference
branch
from
October 29, 2026 00:09
6f798e8 to
3ff19ad
Compare
bvolpato
marked this pull request as ready for review
October 29, 2026 00:27
Contributor
Author
|
This is ready for review now, thanks. |
adriangb
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fork CI setup: For pull requests from a fork to
main, enable workflows in your fork's Actions tab before you push.See the fork CI setup guide.
Which issue does this PR close?
Part of #26759 and #13813.
Rationale for this change
The null-aware join fuzzer reruns each reference query for every batch-size and partition configuration. Each seed uses immutable tables, so those expected rows can be computed once and reused.
What changes are included in this PR?
Build the query cases once and cache their reference rows per seed in a single-partition reference context. Every actual query/configuration combination still runs, with the existing diagnostics and anti-join plan-shape assertions.
What is the testing strategy for this PR?
Original paired
ci-profile runs with the same worker limit took 211s before the change and 118s after it. These are single runs on a shared Linux host. Reference-query executions fall by about 83% while actual-query coverage is unchanged.The existing differential test exercises the cached results and every actual query configuration:
cargo test --profile ci -p datafusion --test extended_tests --features extended_tests null_aware_join_matches_referenceThe full
./dev/rust_lint.shchecks (including formatting and both Clippy configurations) and the extended workspace suite passed after rebasing onto currentmain. The RSS sampler fix from #26445 is now included inmain.Are there any user-facing changes?
None. This changes the test harness only.
AI-assisted contribution.