Repository navigation
fix: Only apply SingleDistinctToGroupBy rewrite when it pays (closes #25932) #26000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mohitgurav20
wants to merge
37
commits into
apache:main
Choose a base branch
from
mohitgurav20:fix/single-distinct-groupby-memory-usage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+415
−2
Open
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
ac76b0d
fix: only apply SingleDistinctToGroupBy rewrite when it pays (closes …
mohitgurav20 09f9d96
Merge branch 'main' into fix/single-distinct-groupby-memory-usage
mohitgurav20 bbf4ccb
test: cover rewrite_pays for unsupported distinct handling in SingleD…
mohitgurav20 222ff4e
feat: add single_distinct_aggregation_prefer_memory optimizer option
mohitgurav20 cca6cd2
Merge branch 'main' into fix/single-distinct-groupby-memory-usage
mohitgurav20 f9c72ea
feat(optimizer): refine single distinct rewrite decision tree
mohitgurav20 3739116
Merge branch 'main' into fix/single-distinct-groupby-memory-usage
mohitgurav20 df3a448
test(optimizer): add branch coverage tests for is_single_distinct_agg
mohitgurav20 7f375a3
Merge branch 'main' into fix/single-distinct-groupby-memory-usage
mohitgurav20 1609f89
fix(docs): escape angle brackets in is_single_distinct_agg doc comment
mohitgurav20 d3e37ce
Merge branch 'main' into fix/single-distinct-groupby-memory-usage
mohitgurav20 4587fde
fix(optimizer): preserve count rollup guard and update tpch q16 plan
mohitgurav20 341df0f
Merge branch 'main' into fix/single-distinct-groupby-memory-usage
mohitgurav20 51f1775
test(sqllogictest): update plan snapshots for single distinct to grou…
mohitgurav20 38468c5
Merge branch 'main' into fix/single-distinct-groupby-memory-usage
mohitgurav20 7e4a93c
Merge branch 'main' into fix/single-distinct-groupby-memory-usage
mohitgurav20 5d437a3
test(optimizer): eliminate unexercised test branches and add avg comp…
mohitgurav20 5aa5906
Merge remote-tracking branch 'apache/main' into fix/single-distinct-g…
mohitgurav20 095b8c7
Merge remote-tracking branch 'apache/main' into fix/single-distinct-g…
mohitgurav20 2a091fa
ci: trigger mergeability recheck after sync with apache/main
mohitgurav20 1682661
Merge remote-tracking branch 'apache/main' into fix/single-distinct-g…
mohitgurav20 03dbe3e
Merge branch 'main' into fix/single-distinct-groupby-memory-usage
mohitgurav20 051a9d2
fix(optimizer): gate single distinct rewrite with single_distinct_agg…
mohitgurav20 eb2cd8a
Merge branch 'main' into fix/single-distinct-groupby-memory-usage
mohitgurav20 8024c82
fix: resolve intra-doc link for DistinctHandling in single_distinct_t…
mohitgurav20 a077c0c
Merge branch 'main' into fix/single-distinct-groupby-memory-usage
mohitgurav20 8071b00
Merge remote-tracking branch 'apache/main' into fix/single-distinct-g…
mohitgurav20 b4f3d08
feat(optimizer): refine prefer_memory guard to avoid regressions on s…
mohitgurav20 16000fe
Merge remote-tracking branch 'apache/main' into fix/single-distinct-g…
mohitgurav20 2341fe3
style: format single_distinct_to_groupby.rs
mohitgurav20 f45925c
docs: fix doc comment placement in single_distinct_to_groupby.rs
mohitgurav20 93e3746
Merge branch 'main' into fix/single-distinct-groupby-memory-usage
mohitgurav20 c8df6bc
Merge remote-tracking branch 'apache/main' into fix/single-distinct-g…
mohitgurav20 24155f6
style: add trailing newline to single_distinct_to_groupby.slt
mohitgurav20 c413a0e
Merge remote-tracking branch 'apache/main' into fix/single-distinct-g…
mohitgurav20 defd182
Merge remote-tracking branch 'apache/main' into fix/single-distinct-g…
mohitgurav20 1f7c26b
fix: address review feedback on float distinct semantics and document…
mohitgurav20 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#25988 (merged today, not released yet) added
single_distinct_prefer_nativejust below for the same choice, and with both settingscount(DISTINCT int)at one target partition skips the rewrite under either one. Could this PR widen that setting's gate instead of adding a second setting? Because it hasn't been released, its name and doc can still change, and users would get one switch for "keep grouped DISTINCT native".