fix: Add a subquery when unparsing a Filter depending on a Projection - #25549
Open
nuno-faria wants to merge 2 commits into
Open
nuno-faria wants to merge 2 commits into
nuno-faria wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25549 +/- ##
==========================================
- Coverage 82.41% 82.41% -0.01%
==========================================
Files 1138 1138
Lines 435299 435317 +18
Branches 435299 435317 +18
==========================================
+ Hits 358749 358759 +10
- Misses 54840 54848 +8
Partials 21710 21710 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When we have a
Filternext to aProjection, we might not be able to unparse them at the same level if the predicate depends on columns aliased by the projection. For those cases, we need to add a subquery in between.What changes are included in this PR?
Filteris aliased by aProjectiondirectly below it, a subquery is added withderive.What is the testing strategy for this PR?
Unit tests.
Are there any user-facing changes?
No, this only adds the subquery when it is necessary, so existing tests remain unchanged.