fix: Substrait serialization mishandles sliced map literals - #25543
Open
neilconway wants to merge 2 commits into
Open
neilconway wants to merge 2 commits into
neilconway wants to merge 2 commits into
Conversation
Contributor
Author
|
Not sure if there's anything to be done about the confusing nature of the APIs here... |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25543 +/- ##
=========================================
Coverage 82.38% 82.39%
=========================================
Files 1138 1138
Lines 433739 434744 +1005
Branches 433739 434744 +1005
=========================================
+ Hits 357338 358193 +855
- Misses 54847 54861 +14
- Partials 21554 21690 +136 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
ScalarValue::Maphas an unfortunate property: it exposes thekeys()andvalues()methods from the underlying ArrowMapArray, but those methods return all of the keys/values in the backing array, not just keys/values in the visible span. As a result, callingkeys()on aScalarValue::Mapcan return values outside the logical content of the scalar map.Fix an instance of this bug in the substrait serialization code.
What changes are included in this PR?
What is the testing strategy for this PR?
Existing tests pass, new test added.
Are there any user-facing changes?
No, aside from fixing the bug.