FilterExec : expose push_batch_with_filter on LimitedBatchCoalescer - #25503
Open
Rich-T-kid wants to merge 4 commits into
Open
Rich-T-kid wants to merge 4 commits into
Rich-T-kid wants to merge 4 commits into
Conversation
Contributor
Author
|
run benchmarks |
Arrow's BatchCoalescer already has push_batch_with_filter, which writes surviving rows directly into the coalescer buffer in a single pass. LimitedBatchCoalescer was not exposing it, forcing FilterExec to call filter_record_batch first (materialising a new allocation) and then push_batch (a second copy). Wire push_batch_with_filter through LimitedBatchCoalescer with correct fetch-limit accounting, and update FilterExec to use it, eliminating the intermediate allocation on the hot filter path.
Contributor
Author
|
run benchmarks |
Rich-T-kid
marked this pull request as draft
September 19, 2026 15:59
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/expose-push-batch-with-filter (d418c19) to 6e4d9ba (merge-base) diff Run configurationrun benchmark tpchResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/expose-push-batch-with-filter (d418c19) to 6e4d9ba (merge-base) diff Run configurationrun benchmark tpcdsResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/expose-push-batch-with-filter (d418c19) to 6e4d9ba (merge-base) diff Run configurationrun benchmark clickbench_partitionedResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/expose-push-batch-with-filter (d418c19) to 6e4d9ba (merge-base) diff Run configurationrun benchmark tpcdsResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/expose-push-batch-with-filter (d418c19) to 6e4d9ba (merge-base) diff Run configurationrun benchmark clickbench_partitionedResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/expose-push-batch-with-filter (d418c19) to 6e4d9ba (merge-base) diff Run configurationrun benchmark tpchResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/expose-push-batch-with-filter (d418c19) to 6e4d9ba (merge-base) diff Run configurationrun benchmark tpchCPU Details (lscpu)Details
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/expose-push-batch-with-filter (d418c19) to 6e4d9ba (merge-base) diff Run configurationrun benchmark tpchCPU Details (lscpu)Details
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/expose-push-batch-with-filter (d418c19) to 6e4d9ba (merge-base) diff Run configurationrun benchmark tpcdsCPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/expose-push-batch-with-filter (d418c19) to 6e4d9ba (merge-base) diff Run configurationrun benchmark tpcdsCPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/expose-push-batch-with-filter (d418c19) to 6e4d9ba (merge-base) diff Run configurationrun benchmark clickbench_partitionedCPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/expose-push-batch-with-filter (d418c19) to 6e4d9ba (merge-base) diff Run configurationrun benchmark clickbench_partitionedCPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25503 +/- ##
==========================================
+ Coverage 82.36% 82.41% +0.05%
==========================================
Files 1137 1138 +1
Lines 433123 435454 +2331
Branches 433123 435454 +2331
==========================================
+ Hits 356746 358892 +2146
- Misses 54846 54849 +3
- Partials 21531 21713 +182 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rich-T-kid
force-pushed
the
rich-T-kid/expose-push-batch-with-filter
branch
from
September 19, 2026 20:19
d418c19 to
f471266
Compare
Rich-T-kid
changed the title
Rich-T-kid
marked this pull request as ready for review
September 19, 2026 20:32
Contributor
|
Thanks @Rich-T-kid , test coverage issue Fetch logic of #[test]
fn test_push_batch_with_filter_nulls_and_fetch() {
let batch = uint32_batch(0..8);
let mut coalescer = LimitedBatchCoalescer::new(batch.schema(), 100, Some(3));
let filter = BooleanArray::from(vec![
None,
Some(true),
None,
Some(false),
Some(true),
Some(true),
None,
Some(true),
]);
assert_eq!(
coalescer.push_batch_with_filter(batch, &filter).unwrap(),
PushBatchStatus::LimitReached,
);
coalescer.finish().unwrap();
let output = coalescer.next_completed_batch().unwrap();
let expected = UInt32Array::from(vec![1, 4, 5]);
assert_eq!(output.column(0).as_ref(), &expected as &dyn arrow::array::Array);
} |
jayzhan211
reviewed
Sep 20, 2026
Contributor
Author
|
run benchmarks |
Contributor
Author
|
@jayzhan211 thank you for the review, the latest commit should address your comments 🚀 |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/expose-push-batch-with-filter (6b1623c) to 6e4d9ba (merge-base) diff Run configurationrun benchmark tpcdsResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/expose-push-batch-with-filter (6b1623c) to 6e4d9ba (merge-base) diff Run configurationrun benchmark clickbench_partitionedResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/expose-push-batch-with-filter (6b1623c) to 6e4d9ba (merge-base) diff Run configurationrun benchmark tpchResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/expose-push-batch-with-filter (6b1623c) to 6e4d9ba (merge-base) diff Run configurationrun benchmark tpchCPU Details (lscpu)Details
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/expose-push-batch-with-filter (6b1623c) to 6e4d9ba (merge-base) diff Run configurationrun benchmark tpcdsCPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/expose-push-batch-with-filter (6b1623c) to 6e4d9ba (merge-base) diff Run configurationrun benchmark clickbench_partitionedCPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
we should be able to avoid an intermediate record batch allocation by using
push_batch_with_filterWhat changes are included in this PR?
Exposes
push_batch_with_filteron LimitedBatchCoalescer and switches FilterExec to use it instead of callingfilter_record_batchfollowed bypush_batch.What is the testing strategy for this PR?
Are there any user-facing changes?
no