DRAFT: Test aggmetrics submetrics - #25180

Closed

kosiew wants to merge 24 commits into

apache:mainfrom

kosiew:test-aggmetrics

Commits on Sep 9, 2026

feat: add data‑free SQL harness for array_agg_distinct benchmark
kosiew
committed
2af67d8
chore: adjust benchmark scope from 1M to 100K groups
kosiew
committed
8a0786e

Commits on Sep 11, 2026

bench: scale array_agg distinct groups
kosiew
committed
d91528d
empty commit
kosiew
committed
7a7bd21
feat: add optional AggregateMetric API with lazy internal timers and comprehensive tests
kosiew
committed
b741b38
feat(metrics): safe refactors to avoid redundant allocations and improve performance
kosiew
committed
fe70140
fix: assert both internal_distinct timers are >0 in test
kosiew
committed
1e4acde
docs: update metrics.md with identity/cardinality, accumulator timer, partition display, and empty input behavior
kosiew
committed
3105148
fix(DistinctArrayAggAccumulator): correct `size()` calculation
kosiew
committed
b26e09d
feat(aggregates): add 2‑partition execution test and fix array_agg distinct identities and timer handling
kosiew
committed
5cfb718
feat(metrics): add lock‑free OnceLock fast path for AggregateSubMetrics
kosiew
committed
62c6f88
fix: restore Time::add min‑1ns behavior and remove exact‑duration API
kosiew
committed
ba29605
fix(time): corrected split to preserve exact duration adds and avoid per‑batch 1 ns inflation
kosiew
committed
c684057
feat(metrics): require RefUnwindSafe for AggregateMetric and add compile‑time test for DistinctArrayAggAccumulator
kosiew
committed
132a785
test: add legacy grouped `array_agg(DISTINCT)` metric test
kosiew
committed
dfc2f91
fix(array_agg): skip internal DISTINCT timing for small batches and improve per-group metrics
kosiew
committed
d86b9bf
feat(datafusion): add grouped update metric and update_batch_grouped for accumulators
kosiew
committed
33b0f17
fix(groups_accumulator): improve Instant usage and fix unnecessary Option clone
kosiew
committed
68f98fc
refactor: simplify distinct_metric cloning in DistinctArrayAggAccumulator
kosiew
committed
d087f87
feat(metrics): add array_agg(DISTINCT) merge, convert_to_state, and metric-count regressions
kosiew
committed
8a3f79c
feat: cache aggregate metric handles for grouped accumulators
kosiew
committed
98533fc
feat(groups-accumulator-adapter): move slice/filter prep outside timing, bound prep chunks, time only accumulator calls, and emit one metric update per logical batch
kosiew
committed
1b9cde4
feat: convert_to_state uses bounded 64‑row prep chunks with timer‑wrapped batch updates and adds regression test
kosiew
committed
a00e324
refactor: simplify metric lookup and consolidate implementation blocks, import AggregateMetrics
kosiew
committed
16a9573

Navigation Menu

Uh oh!

DRAFT: Test aggmetrics submetrics - #25180

DRAFT: Test aggmetrics submetrics#25180
kosiew wants to merge 24 commits into
apache:mainfrom
kosiew:test-aggmetrics

Commits on Sep 9, 2026

feat: add data‑free SQL harness for array_agg_distinct benchmark

chore: adjust benchmark scope from 1M to 100K groups

Commits on Sep 11, 2026

bench: scale array_agg distinct groups

empty commit

feat: add optional AggregateMetric API with lazy internal timers and comprehensive tests

feat(metrics): safe refactors to avoid redundant allocations and improve performance

fix: assert both internal_distinct timers are >0 in test

docs: update metrics.md with identity/cardinality, accumulator timer, partition display, and empty input behavior

fix(DistinctArrayAggAccumulator): correct `size()` calculation

feat(aggregates): add 2‑partition execution test and fix array_agg distinct identities and timer handling

feat(metrics): add lock‑free OnceLock fast path for AggregateSubMetrics

fix: restore Time::add min‑1ns behavior and remove exact‑duration API

fix(time): corrected split to preserve exact duration adds and avoid per‑batch 1 ns inflation

feat(metrics): require RefUnwindSafe for AggregateMetric and add compile‑time test for DistinctArrayAggAccumulator

test: add legacy grouped `array_agg(DISTINCT)` metric test

fix(array_agg): skip internal DISTINCT timing for small batches and improve per-group metrics

feat(datafusion): add grouped update metric and update_batch_grouped for accumulators

fix(groups_accumulator): improve Instant usage and fix unnecessary Option clone

refactor: simplify distinct_metric cloning in DistinctArrayAggAccumulator

feat(metrics): add array_agg(DISTINCT) merge, convert_to_state, and metric-count regressions

feat: cache aggregate metric handles for grouped accumulators

feat(groups-accumulator-adapter): move slice/filter prep outside timing, bound prep chunks, time only accumulator calls, and emit one metric update per logical batch

feat: convert_to_state uses bounded 64‑row prep chunks with timer‑wrapped batch updates and adds regression test

refactor: simplify metric lookup and consolidate implementation blocks, import AggregateMetrics